summaryrefslogtreecommitdiff
path: root/src/caja-places-sidebar.c
AgeCommit message (Collapse)AuthorFilesLines
2019-04-10local #include files inside "" instead <>Pablo Barciela1-21/+24
2019-03-07avoid variables set but not usedPablo Barciela1-5/+0
2018-12-02caja-places-sidebar: replace two other uses of g_drive_poll_for_media_finishlukefromdc1-2/+2
Both of these uses are incorrect and if this code is ever run would likely segfault. Adapted from https://github.com/linuxmint/nemo/commit/4ffea61b26033da1305ab8287058044065a1c101
2018-12-02Fix segfault on stopping USB hard driveslukefromdc1-1/+1
Fix https://github.com/mate-desktop/caja/issues/1046 drive_stop_cb should never have used g_drive_poll_for_media_finish which is for ejectable media in a fixed drive (e.g CD drive) and not for stopping a removable drive
2018-05-10eel-gtk-extensions: replace deprecated gtk_menu_popup functionraveit651-2/+0
2018-04-18sidebar popup menu: show "media-eject" icon in the "unmount" itemsPablo Barciela1-1/+1
2018-04-10sidebar popup menu: show "media-eject" iconPablo Barciela1-1/+1
2018-04-04HiDPI: Convert Pixbufs to Cairo SurfacesVictor Kareh1-18/+34
This allows icons in most places to scale up properly for HiDPI displays.
2018-04-04Support HiDpi iconsCosimo Cecchi1-3/+6
Port the rendering of icons to cairo surfaces, so that we can apply the GDK scale factor when rendering icons. origin commit: https://gitlab.gnome.org/GNOME/nautilus/commit/0d4555d7
2018-03-31caja-places-sidebar.c: avoid deprecated GtkImageMenuItemPablo Barciela1-17/+19
avoid deprecated: gtk_image_menu_item_new_with_mnemonic gtk_image_menu_item_new_with_label gtk_image_menu_item_set_image
2018-02-09avoid deprecated GtkStockPablo Barciela1-2/+2
2018-01-31require GTK+ 3.22 and GLib 2.50monsta1-2/+1
2018-01-01places-sidebar: show user's home dir when it is also the desktoplukefromdc1-25/+25
Current behavior is to show Desktop but hide the user's home directory in the sidebar when desktop-is-home-directory is set. This is opposite what would be expected so invert it. Patch by https://github.com/TomaszGasior
2017-12-31places-sidebar: remove duplicate functionlukefromdc1-3/+0
This is already handled in libcaja-private/caja-file-operations.c
2017-12-14Fix #880 and fix refusal to unmount when sidebar is widelukefromdc1-44/+23
caja-places-sidebar: revert all kludges for eject behavior: Revert https://github.com/mate-desktop/caja/commit/d14fef384a435471860130f7337d5dea5bb824a0 https://github.com/mate-desktop/caja/commit/9b2e152876067aaee3baa699c51c6c6174d4954e and https://github.com/mate-desktop/caja/commit/30f19d0aed3e40a3682f820059ebb8b3038ba84e the last being a subset of a commit we'll apply later caja-places-sidebar: fix eject button hover, eject behavior Apply https://github.com/GNOME/nautilus/commit/f294a4e80626793624d76d6002b094d1c0809de4 "Fix up eject button hover in places sidebar" We were calling gtk_tree_view_column_cell_get_position() without properly loading the cell attribute for the right row before. We fix this by calling gtk_tree_view_column_cell_set_cell_data(). With this in place we can also use the x_offset for the position and avoid the whole summing of widths. Due to a bug in Gtk which expands the eject icon cell renderer we have to right align it so that it lines up properly. https://bugzilla.gnome.org/show_bug.cgi?id=640741 caja-places-sidebar: disable overlay scrollbar disable overlay scrollbars as they force the use of too much padding
2016-11-22move to GTK+3 (>= 3.14), drop libunique, GTK+2 code, and --with-gtk build ↵lukefromdc1-31/+1
option *Remove GTK_VERSION_CHECK (3, 0, 0) and libunique selectors *Remove GTK2 and libunique specific code. *Leaves selector for specific GTK3 versions. *Remove #DEFINES for vbox/hbox previously required for GTK2 compatability *Keep vbox in caja-spatial-window.c, it is necessary for the desktop to work *spatial-window vbox issue at https://github.com/mate-desktop/caja/issues/591
2016-10-23libunique builds: enable eject notificationslukefromdc1-18/+4
We no longer need to use any GtkApplication features for this so enable it in libunique builds too. Tested with and without libunique in GTK 3.22
2016-10-23Refactor notification code to remove duplicate functionlukefromdc1-4/+4
The desktop icon eject code required a function in libcaja-private so we no longer need it in caja-application.c
2016-10-22GtkApplication: Notify when ejected volumes safe to unpluglukefromdc1-2/+31
Notify users when an external drive is still writing data on attempt to eject, and again when drive is safe to unmount. Notifications behave as they do in Nemo when ejecting/unmounting a flash drive. Tested with GTK 3.22 and a known slow flash drive. This is in GtkApplication builds only, code is from Nemo. FIXME: build system does not limit libnotify dependency to GtkApplication builds and is rather improvised. Adding libnotify to CORE_MODULES via configure.ac did not work, and using Nemo's changes put -lnotify into CORE rather than ALL libs and that caused build failures on failure to link.
2016-10-14GTK2: Use emanuele-f 's patch for build failure, fix build w/o libuniquelukefromdc1-2/+2
Apply https://github.com/mate-desktop/caja/pull/658/commits/4b36a91af42d8efe0f594a95d28ab8448fd73b31 then fix the selectors in source files to use the boolean selectors for libunique
2016-10-08GTK3: port libunique ->GtkApplication as build time optionlukefromdc1-0/+4
Add --disable-libunique configuration option for GTK3 builds. This builds a port from libunique to GtkApplication. keep GTK2 builds unchanged Caja can now be build with GTK2 and libunique, GTK3 and libunique, or GTK3 without libunique using GtkApplication instead GtkApplication port Based on cherrypicked nautilus commits from https://github.com/GNOME/nautilus/commit/a8481ee4bd8d34e792d63598fa5efb47736f9de4 main: adapt to GtkApplication changes through https://github.com/GNOME/nautilus/commit/c3382e0415d51082545f277c380d37be160e8d2d application: move nautilus_application_new() to its own function GTK3/GtkApplication builds: add --force-desktop option This is useful for other DE's All: StartupNotify=false in .desktop files, as caja never connects to notification daemons and in GtkApplication builds this causes busy spinning curors
2016-05-30GTK+3 sidebars and caja-places: port style_set to style_updatedraveit651-5/+8
2016-05-28GTK3: caja-places-sidebar.c use GtkStyleContextlukefromdc1-0/+10
caja-places-sidebar.c: Port caja_places_sidebar_style_set to GtkStyleContext from GtkStyle in GTK3 builds
2016-01-13GTK3 general: use eel_create_spotlight_pixbuf()Wolfgang Ulbrich1-0/+9
taken from: https://git.gnome.org/browse/nautilus/commit/?h=gnome-3-0&id=8b13a04
2015-10-14Gtk3 places-sidebar: fixes accidental device ejectraveit651-0/+5
2015-06-18places-sidebar: enable both creating bookmarks and dropping filesMonsta1-6/+18
- drag a folder to the top or bottom of the bookmark list to add a new bookmark. a horizontal line will be shown and the mouse pointer will have a '+' at its right side. - if there are no bookmarks (and that section isn't shown), drag a folder over the network section's heading. this will add a new bookmark and make the bookmarks list visible. - drag a file or a folder over some existing bookmark to move it into the bookmarked folder. the mouse pointer will have an arrow at its right side. - if you want to copy a file or a folder there instead, perform the same operation but hold ctrl during that. the mouse pointer will have a '+' at its right side. no horizontal line will be shown, so you will be able to distinguish this operation from adding a new bookmark. :) adapted from https://github.com/linuxmint/nemo/commit/f18c4dd842be0998cbe6a519d9904bfd9993ca3e (thanks to @mtwebster) fixes https://github.com/mate-desktop/caja/issues/345 closes https://github.com/mate-desktop/caja/issues/423
2015-06-18places sidebar: fix indentation a bitMonsta1-8/+6
2015-06-11Merge pull request #424 from flexiondotorg/masterMartin Wimpress1-14/+115
Revert "places-sidebar: allow dropping of files to bookmarks"
2015-06-11Revert "places-sidebar: allow dropping of files to bookmarks"Martin Wimpress1-14/+115
This reverts commit 910b9141ac634a86d8f53fda534e33787a160efb.
2015-03-19places-sidebar: fix crashMonsta1-2/+4
taken from upstream commits: https://git.gnome.org/browse/nautilus/commit/?id=cda2c75df4b95a481e8b774081ec1240d47fa45f https://git.gnome.org/browse/nautilus/commit/?id=4764a856c7a6e5a84d4067e7b105c09a93ffdbe4 Closes https://github.com/mate-desktop/caja/pull/395
2015-01-13drop support for GLib < 2.36Monsta1-2/+0
Closes https://github.com/mate-desktop/caja/pull/372
2014-12-10properly zero-init a variablemonsta1-1/+1
2014-05-17propagate button-release event when ejecting, fixes #169alexandervdm1-3/+2
See also gnome bug https://bugzilla.gnome.org/show_bug.cgi?id=646302
2014-03-21places-sidebar: allow dropping of files to bookmarksraveit651-115/+14
2014-03-21sidebar: rearranged of caja sidebar to 1.4 styleraveit651-154/+156
2013-02-24Fix issues with XDG dirs in places sidebarStefano Karapetsas1-1/+12
2013-02-24More indentation fixesStefano Karapetsas1-19/+19
2013-02-24Indentation fixesStefano Karapetsas1-423/+424
2012-12-22[places-sidebar] plug leak in _dispose, add g_clear_object in glibcomat.hJasmine Hassan1-15/+5
to cleanup code a bit. http://git.gnome.org/browse/nautilus/commit/?id=c6fa6b2062a1adf3e4945824048b3771edb35ebe for g_clear_object compatibility: https://gitorious.org/vaapi/gstreamer-vaapi/commit/ab2ec5e2541834c2490a78ec839850df2b075cf5?format=diff
2012-11-23[all] include src/glibcompat.h & use g_list_free_full() where neededJasmine Hassan1-2/+3
Also fixes a double-free regression in lc-p/caja-query from 7a42b9b0
2012-11-16[places-sidebar] use gtk_widget_set_visible() instead of the eel helperJasmine Hassan1-9/+9
http://git.gnome.org/browse/nautilus/commit/?id=bb145a018a9d66b748971e40be4e09a7f843b2be
2012-11-16[all] use g_list_free() and g_strcmp0 instead of eel functionsJasmine Hassan1-3/+4
Was: general: use g_list_free_full() instead of eel functions http://git.gnome.org/browse/nautilus/commit/?id=5e669515fd7f760382e6b7aa1449734a35a2d7f4 . Instead of g_list_free_full(), we use g_list_foreach and g_list_free() to avoid unnecessary glib dependency bump to 2.28
2012-11-16[src] convert to new GDK_KEY prefixJasmine Hassan1-8/+8
http://git.gnome.org/browse/nautilus/commit/?id=71fa1a50145a6f06da3b805a29e75c1295fd546b Also, make sure we use GDK_KEY prefix in places-sidebar where this patch was previously applied to Caja but with old prefix: places-sidebar: allow keyboard navigation with Enter/Space (#637768) http://git.gnome.org/browse/nautilus/commit/?id=fd03c910a73ba18459e68baaf15e8dd295acd5c1
2012-11-16[places-sidebar] redesign the Places sidebarJasmine Hassan1-264/+556
According to http://live.gnome.org/Nautilus/UIRoadmap/Places http://git.gnome.org/browse/nautilus/commit/?id=a59e586adf32eea64c9c4ae08a5482d2a9c37fb1 Small followup commits also included in this commit: icon-names: fix a typo http://git.gnome.org/browse/nautilus/commit/?id=2f847f37f429062d58df3927d10bc52c67a4524f sidebar: fix bookmark renaming http://git.gnome.org/browse/nautilus/commit/?id=1fdfa522da3e7c672fe4202c591a928c8796bb06 sidebar: add myself to the authors (Cosimo Cecchi <[email protected]>) http://git.gnome.org/browse/nautilus/commit/?id=0f7e56b5e0ae5134ed1d8caeadcb3c684ae7f661 sidebar: don't allow selecting headers http://git.gnome.org/browse/nautilus/commit/?id=8277ddc798fc78793364b54444fa53e9a287b5cc sidebar: don't try to add non-existing special dirs http://git.gnome.org/browse/nautilus/commit/?id=0f70ac4bb782b3c3fb0f5e8a24032cb344fdb2cc
2012-11-16[places-sidebar] fix eject button highlightingJasmine Hassan1-23/+33
http://git.gnome.org/browse/nautilus/commit/?id=2d9d47254908533d1eb20e16e091f91310052e93
2012-11-16[pathbar] release the highlight path on disposeJasmine Hassan1-6/+8
http://git.gnome.org/browse/nautilus/commit/?id=fd75e8f5e8b160eaba22ca4ed7efc852dba612a0
2012-11-16[places-sidebar] don't update the icon if it's not visibleJasmine Hassan1-21/+37
This greatly reduces the number of times we have to create a pixbuf (only once-per-highlight now). http://git.gnome.org/browse/nautilus/commit/?id=6f5777b81958ce6f3dbc6bac3323d423d3dcc20b
2012-11-16[pathbar] make sure |path| is always valid and memory releasedJasmine Hassan1-6/+10
http://git.gnome.org/browse/nautilus/commit/?id=a43bc7def3976947b9624113d18167211e76f9b8
2012-11-16[places-sidebar] use _icon_info_lookup_from_name()Jasmine Hassan1-5/+5
http://git.gnome.org/browse/nautilus/commit/?id=f4ae07c8741d2e8cc6b96450c8bb86e532b59137
2012-11-16[places-sidebar] Add highlight to eject iconJasmine Hassan1-22/+136
Add highlight to eject icon in places sidebar (#544103) http://git.gnome.org/browse/nautilus/commit/?id=63b2cac301970847f76f7bdbd12835117958d9be