summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2019-04-16caja-location-dialog: Fix 'cppcheck' and 'clang' warningsPablo Barciela1-5/+5
Fixes 'cppcheck' warnings: [src/caja-location-dialog.c:229] -> [src/caja-location-dialog.c:237]: (warning) Either the condition 'window' is redundant or there is possible null pointer dereference: window. [src/caja-location-dialog.c:224]: (style) The scope of the variable 'formatted_location' can be reduced. Fixes Clang static analyzer warning: caja-location-dialog.c:237:12: warning: Access to field 'details' results in a dereference of a null pointer (loaded from variable 'window') slot = window->details->active_pane->active_slot; ^~~~~~~~~~~~~~~
2019-04-14caja-property-browser: Fix cast from non-struct type to struct typePablo Barciela1-4/+4
Fixes Clang static analyzer warnings: caja-property-browser.c:1242:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER (data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ caja-property-browser.c:1414:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER (data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ caja-property-browser.c:1450:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER(data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-12local #include files who are libraries inside <> instead ""Pablo Barciela80-559/+559
2019-04-10drop functions defined but not usedPablo Barciela6-463/+0
2019-04-10local #include files inside "" instead <>Pablo Barciela80-753/+902
2019-04-09Fix invocation with --geometry from the command linelukefromdc1-7/+14
Due to changes somewhere else windows called with --geometry must now be opened before splitedOptions is freed or the geometry passed to later functions gets corrrupted Note that setting a width smaller than 654 px will generate GTK warnings (negative content width and similar) but will still mostly work.
2019-04-08Pass "NULL" for keyboard eventlukefromdc2-2/+10
Fix #1198 "Context menu with menu key broken" Pass "NULL" for event which is passed ultimately to gtk_menu_popup_at_pointer as an invalid event was being passed when the menu key was used to open the icon views context menu
2019-04-07caja-application: avoid NULL inside 'g_object_unref'Pablo Barciela1-3/+4
Fixes Clang static analyzer warning: caja-application.c:2221:25: warning: Array access (from variable 'files') results in a null pointer dereference g_object_unref (files[idx]); ^~~~~~~~~~
2019-04-05fm-desktop-icon-view: remove dead codePablo Barciela1-11/+1
Fixes Clang static analyzer warnings: fm-desktop-icon-view.c:331:33: warning: 1st function call argument is an uninitialized value if (pointer == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_MOUSE)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~ fm-desktop-icon-view.c:335:34: warning: 1st function call argument is an uninitialized value if (keyboard == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_KEYBOARD)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-03-29eel: remove g_object_list_copyrbuj3-4/+4
GNOME/nautilus@7af24a8 Replace GList * eel_g_object_list_copy (GList *list) with g_list_copy_deep (list, (GCopyFunc) g_object_ref, NULL)
2019-03-28caja-sidebar-title: avoid 'NULL' inside 'setup_gc_with_fg'Pablo Barciela1-1/+1
Fixes Clang static analyzer warning: caja-sidebar-title.c:233:49: warning: Dereference of null pointer (loaded from variable 'color') sidebar_title->details->label_colors[idx] = *color; ^~~~~~
2019-03-07avoid variables set but not usedPablo Barciela9-46/+7
2019-03-06caja-window: Fix garbage valuePablo Barciela1-1/+2
Fixes Clang static analyzer warning: caja-window.c:554:34: warning: The left operand of '<' is a garbage value MIN (default_width, ^ ~~~~~~~~~~~~~
2019-03-05Fix attempt to free released memoryrbuj1-1/+0
2019-03-04fm-tree-model: Fix use of memory after it is freedPablo Barciela1-2/+6
to avoid warning with Clang Analyzer
2019-03-04caja-information-panel: Fix use of memory after it is freedPablo Barciela1-1/+4
to avoid warning with Clang Analyzer
2019-03-04fm-directory-view: Fix use of memory after it is freedPablo Barciela1-1/+1
to avoid warning with Clang Analyzer
2019-03-04[Security] Use 'g_strlcpy' instead of 'strcpy'Pablo Barciela1-1/+1
to avoid warnings with Clang Analyzer
2019-03-04drop unused variablesPablo Barciela5-5/+0
2019-02-18Read authors and documenters fom caja.about filerbuj3-109/+37
2019-02-17Ensure proper translation of the about dialog titlerbuj1-0/+1
Note that GTK+ sets a default title of _("About %s") on the dialog window (where %s is replaced by the name of the application, but in order to ensure proper translation of the title, applications should set the title property explicitly when constructing a GtkAboutDialog https://developer.gnome.org/gtk3/stable/GtkAboutDialog.html
2019-02-14Update authorsrbuj1-4/+59
Merged the authors with the new ones: git log --pretty="%an <%ae>" --since "2012-01-01" -- . "*.h" "*.c" | sort | uniq
2019-02-13Update Documentersrbuj1-1/+2
Update "Documented by" in About Caja dialog
2019-02-06Add --disable-self-check for configureWu Xiaotian1-0/+2
Fixed make distcheck, see #1129
2019-02-02Avoid deprecated g_type_class_add_private under srcWu Xiaotian6-57/+17
Changed CajaInformationPanel, CajaLocationBar and CajaNavigationAction
2019-02-02Fix incompatible pointer typesVictor Kareh3-6/+6
2019-01-31Avoid deprecated g_type_class_add_private under srcWu Xiaotian8-55/+29
Changed CajaSidePane, CajaSpatialWindow, CajaViewAsAction and CajaXContentBar
2019-01-31Avoid deprecated g_type_class_add_private under srcWu Xiaotian6-31/+24
Changed CajaConnectServerOperation, CajaDesktopWindow and CajaImagePropertiesPage
2019-01-29Fix compile warningWu Xiaotian1-18/+21
Remove unused variables, avoid uninitialized variable warnings, and indent code.
2019-01-28Let file size units follow the users preferenceWu Xiaotian1-22/+49
2019-01-28Fixed the value of 6 month and 1 year.Wu Xiaotian1-9/+49
2019-01-28Support querying files by modification time and sizeWu Xiaotian1-2/+253
Thanks for Leslie Zhai's patch.
2019-01-28Avoid deprecated g_type_class_add_privateWu Xiaotian21-118/+81
- caja-connect-server-dialog - caja-navigation-window - caja-property-browser - caja-sidebar-title - caja-trash-bar - caja-window - caja-zoom-action - caja-zoom-control - fm-desktop-icon-view - fm-properties-window
2019-01-24Update copyright to 2019Wu Xiaotian1-1/+1
2019-01-22CajaApplication: avoid deprecated 'g_type_class_add_private'Wu Xiaotian2-8/+6
2019-01-19caja-application: Check for smclient before trying to load sessionlukefromdc1-3/+3
Fix crash on starting with env DESKTOP_AUTOSTART_ID=ANY_CHARS caja
2019-01-03[libcaja-private] Re-check file MIME type before picking an application.Max Eliaser1-0/+7
An example of when the MIME type might change: a file is initially created with 0 bytes of content, but more data is added later. Empty files are always detected as plain text, but the file might not be empty anymore when the user opens it. This commit affects the behavior when double-clicking a file and when right- clicking on it too.
2019-01-03[file-manager] Fix apparent bug in context menu updating code.Max Eliaser1-1/+1
The code looked like it was supposed to check whether each file in the selection could be opened in an external app, but was only checking the first item in the selection repeatedly. This bug may have been mostly benign since the subsequent call to caja_mime_get_default_application_for_files will return NULL anyway if the files don't all match each other.
2018-12-30Revert "fm-directory-view.c: Decrease minimum update interval."Pablo Barciela1-2/+2
This reverts commit 021ff2ac062f1cfd52726c78e9a3956405001c6e. Fixes https://github.com/mate-desktop/caja/issues/1101
2018-12-27Fix: weird item in bookmarks if the folder was removedPablo Barciela1-9/+33
Fixes https://github.com/mate-desktop/caja/issues/1099
2018-12-27Change show/hide backup files shortcutSargastic1-1/+1
2018-12-27Remove useless comments, correct description stringSargastic2-7/+0
2018-12-27Add independent show/hide backup filesSargastic9-7/+173
2018-12-02caja-places-sidebar: replace two other uses of g_drive_poll_for_media_finishlukefromdc1-2/+2
Both of these uses are incorrect and if this code is ever run would likely segfault. Adapted from https://github.com/linuxmint/nemo/commit/4ffea61b26033da1305ab8287058044065a1c101
2018-12-02Fix segfault on stopping USB hard driveslukefromdc1-1/+1
Fix https://github.com/mate-desktop/caja/issues/1046 drive_stop_cb should never have used g_drive_poll_for_media_finish which is for ejectable media in a fixed drive (e.g CD drive) and not for stopping a removable drive
2018-12-01fm-properties-window: Fix memory leaksPablo Barciela1-6/+13
'g_strconcat' needs to be freed
2018-11-07Fix case-insensitive comparison in running_in_mateZhang Xianwei2-4/+4
The environment variable XDG_SESSION_DESKTOP and DESKTOP_SESSION in running_in_mate are compared using "MATE". Actually the environment variable in MATE DE is "mate"(lower case). Using "mate" instead of "MATE" to fix it. Signed-off-by: Zhang Xianwei <[email protected]>
2018-11-02connect-server-dialog: Respect password save settingTomas Bzatek1-0/+6
The "Remember this password" checkbox was not respected when password was specified and connection succeeded for the first time. https://bugzilla.gnome.org/show_bug.cgi?id=641376 Adapted from https://gitlab.gnome.org/GNOME/nautilus/commit/571a6ef7
2018-11-02properties-window: fix checking inconsistent stateAlexandru Pandelea1-1/+1
In the function initial_permission_state_consistent, when the check was made to see if the files have the same permissions, the check was not correct. To fix this, also do & between the first_permissions and the mask. https://bugzilla.gnome.org/show_bug.cgi?id=698955 Adapted from https://gitlab.gnome.org/GNOME/nautilus/commit/37595852
2018-10-19Add 'Configurable' interface and add support to caja-file-management-properties20kdc1-3/+60
generated by cgit v1.2.1 (git 2.18.0) at 2024-11-09 23:48:32 +0000