summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-09-22Use g_list_free_full and g_slist_free_fullrbuj7-22/+11
void g_list_free_full (GList *list, GDestroyNotify free_func); void g_slist_free_full (GList *list, GDestroyNotify free_func); Convenience methods, which free all the memory used by a list, and calls free_func on every element's data.
2019-09-17dlg-prop: show the exact number of bytes as part of the sizerbuj1-2/+2
2019-09-15dlg-prop: allow to open the archive's folderrbuj1-4/+12
Based on https://github.com/GNOME/file-roller/commit/9a37eb44a8ec5d0a20ea78c9a44c7c9e50bb508f#diff-41f5e2a364a93ff790f678ba58265d43
2019-09-15remove warnings: ‘gtk_image_new_from_stock’ is deprecatedrbuj3-26/+15
gtk-utils.c:171:3: warning: ‘gtk_image_new_from_stock’ is deprecated: Use 'gtk_image_new_from_icon_name' instead [-Wdeprecated-declarations] 171 | image = gtk_image_new_from_stock (text, GTK_ICON_SIZE_BUTTON); | ^~~~~ gtk-utils.c:173:3: warning: ‘gtk_image_new_from_stock’ is deprecated: Use 'gtk_image_new_from_icon_name' instead [-Wdeprecated-declarations] 173 | image = gtk_image_new_from_stock (stock_id, GTK_ICON_SIZE_BUTTON); | ^~~~~
2019-09-15glib-utils & gtk-utils: Remove unused functionsrbuj4-315/+0
cppcheck --enable=unusedFunction .
2019-09-15dlg-package-installer: show icons in error dialog buttonsrbuj1-2/+31
2019-09-15dlg-package-installer: remove warning ‘GtkStock’ is deprecatedrbuj1-2/+2
dlg-package-installer.c:294:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations] 294 | GTK_STOCK_DIALOG_ERROR, | ^~~~~~~~~~~~~~~~~~~~~~ dlg-package-installer.c:297:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations] 297 | GTK_STOCK_CANCEL, GTK_RESPONSE_NO, | ^~~~~~~~~~~~~~~~
2019-09-14gio-utils: Remove unused functionsrbuj2-81/+0
$ cppcheck --enable=unusedFunction . [src/gio-utils.c:1091]: (style) The function 'g_copy_uri_async' is never used. [src/gio-utils.c:1060]: (style) The function 'g_copy_uris_async' is never used.
2019-09-10glib-utils: Remove get_time_string()rbuj4-27/+15
get_time_string() is a local function that wraps strftime(). In contrast to strftime(), g_date_time_format() always produces an UTF-8 string, regardless of the current locale.
2019-09-10unace 2.5: Don't show archive summary in file listingrbuj1-0/+3
closes #303
2019-09-08tar: don't remove leading whitespaces in filename fieldrbuj1-6/+6
closes #299
2019-09-08Initialization discards ‘const’ qualifier from pointer target typerbuj13-43/+43
Remove 317 warnings [-Wdiscarded-qualifiers].
2019-09-07remove warnings: "ENABLE_MAGIC" is not defined, evaluates to 0rbuj1-2/+2
fr-archive.c:45:5: warning: "ENABLE_MAGIC" is not defined, evaluates to 0 [-Wundef] fr-archive.c:519:5: warning: "ENABLE_MAGIC" is not defined, evaluates to 0 [-Wundef]
2019-09-05comparison of integer expressions of different signedness: ‘size_t’rbuj6-11/+11
2019-09-03Missing initializer for struct fieldrbuj27-28/+54
caja-engrampa.c:439:2: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘const struct _GTypeInfo’} [-Wmissing-field-initializers] eggtreemultidnd.c:70:2: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘const struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command.c:98:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-7z.c:750:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-ace.c:334:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-alz.c:397:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-ar.c:383:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-arj.c:429:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command.c:98:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-cfile.c:692:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-cpio.c:319:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-dpkg.c:305:17: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-iso.c:308:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-jar.c:234:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-lha.c:408:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-lrzip.c:262:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-rar.c:832:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-rpm.c:319:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-tar.c:1267:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-unarchiver.c:361:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-unstuff.c:381:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-zip.c:513:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-zoo.c:419:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-window.c:839:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-list-model.c:148:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘const struct _GTypeInfo’} [-Wmissing-field-initializers] fr-process.c:248:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] ui.h:32:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers] ui.h:33:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers] ui.h:34:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers] ui.h:35:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers] ui.h:36:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers]
2019-09-03remove warnings: cast from function call [-Wbad-function-cast]rbuj3-4/+4
dlg-batch-add.c:513:83: warning: cast from function call of type ‘gint’ {aka ‘int’} to non-matching type ‘double’ [-Wbad-function-cast] 513 | gtk_spin_button_set_value (GTK_SPIN_BUTTON (GET_WIDGET ("a_volume_spinbutton")), (double) g_settings_get_int (data->settings, PREF_BATCH_ADD_VOLUME_SIZE) / MEGABYTE); | ^ dlg-new.c:321:81: warning: cast from function call of type ‘gint’ {aka ‘int’} to non-matching type ‘double’ [-Wbad-function-cast] 321 | gtk_spin_button_set_value (GTK_SPIN_BUTTON (data->n_volume_spinbutton), (double) g_settings_get_int (settings, PREF_BATCH_ADD_VOLUME_SIZE) / MEGABYTE); | ^
2019-09-03remove build warning: local variable shadows another variablerbuj4-25/+13
actions.c:245:24: warning: declaration of ‘dialog’ shadows a previous local [-Wshadow] caja-engrampa.c:137:17: warning: declaration of ‘file’ shadows a previous local [-Wshadow] caja-engrampa.c:58:17: warning: declaration of ‘file’ shadows a previous local [-Wshadow] dlg-add-files.c:120:9: warning: declaration of ‘uri’ shadows a previous local [-Wshadow] fr-window.c:4935:11: warning: declaration of ‘value’ shadows a previous local [-Wshadow]
2019-09-02release 1.23.1v1.23.1raveit652-1/+18
2019-09-02tx: sync with transifexraveit65204-1739/+2186
2019-09-02tx: update transifex resourceraveit651-119/+124
2019-09-02java-utils: Remove blank spaces before reading package namerbuj1-3/+14
Closes https://github.com/mate-desktop/engrampa/issues/291 Test: touch test.txt zip test.zip test.txt mv test.zip test.jar cat << EOF > HelloWorld.java package org.mate.tests; class HelloWorld { public static void main(String args[]) { System.out.println("Hello, World"); } } EOF engrampa -a test.jar HelloWorld.java jar tf test.jar Output: test.txt org/mate/tests/HelloWorld.java
2019-09-02fr-command-lrzip: Fix empty string checkrbuj1-1/+1
str is empty: if (*str == '\0') {...}
2019-09-01Redundant redeclaration of ‘fr_command_is_capable_of’rbuj1-2/+0
fr-command.h:205:16: warning: redundant redeclaration of ‘fr_command_is_capable_of’ [-Wredundant-decls]
2019-09-01comparison of unsigned expression >= 0 is always truerbuj1-3/+4
java-utils.c:310:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 310 | for (i = length; (i >= 0) && (end == 0); i-- ) | ^~
2019-08-30gtk-utils: Remove unused wrapper for gtk_builder_new_from_filerbuj3-23/+0
Unused since https://github.com/mate-desktop/engrampa/commit/0d3a5b087f4bb6c118abe34a14ea27b86583f812
2019-08-29glib-genmarshal warning: BOOL token is deprecatedrbuj2-2/+2
2019-08-28comparison of integers of different signs: 'int' and 'guint'rbuj6-28/+28
Fix compiler warning: comparison of integers of different signs: 'int' and 'guint' (aka 'unsigned int') [-Wsign-compare]
2019-08-27glib-utils: Remove unused function - g_ptr_array_copyrbuj2-17/+0
closes https://github.com/mate-desktop/engrampa/issues/283
2019-08-26return sentence won't be never executed as it's preceded by exitrbuj1-2/+1
Detected by clang static analyzer: $ scan-build -enable-checker alpha.deadcode.UnreachableCode --keep-cc -o html-report make ... exit (EXIT_SUCCESS); return TRUE; /* <= This statement is never executed */ ...
2019-08-25Travis CI: clang: -enable-checker alpha.deadcode.UnreachableCodePablo Barciela1-0/+1
2019-07-30Add zcompress supportSergey Ponomarev7-3/+30
2019-07-23caja extension: fix icon name for compress menu itemmonsta1-1/+1
it was using non-existing icon name
2019-07-23fr-window: remove unused struct membersPablo Barciela1-2/+0
Fixes 'cppcheck' warnings: [src/fr-window.c:269]: (style) struct member '_FrWindowPrivateData::tree_hover_path' is never used. [src/fr-window.c:349]: (style) struct member '_FrWindowPrivateData::mitem_recents_menu' is never used.
2019-07-17fr-command-unarchiver: ask password if requiredPablo Barciela1-5/+9
2019-07-01release 1.23.0v1.23.0raveit651-0/+22
2019-07-01tx: sync with transifexraveit65205-77717/+86420
2019-07-01tx: update resource for transifexraveit652-10/+10
2019-07-01Remove trailing whitespacesLaurent Napias22-135/+135
2019-06-11Update FSF addressLaurent Napias95-95/+95
2019-05-31Create FUNDING.ymlMartin Wimpress1-0/+9
2019-05-23travis: use fedora-30 and ubuntu-19.10 for buildingraveit651-2/+2
2019-05-15[ci] Add cppcheck html reportPablo Barciela1-1/+4
2019-05-15Update ui.htamplan1-1/+1
Remove hard-coded 'Back' label button
2019-05-06Avoid deprecated g_type_class_add_privateWu Xiaotian1-7/+4
2019-04-22pre-bump versionraveit652-1/+3
2019-04-21travis: enable 'cppcheck' in debianPablo Barciela1-0/+4
2019-04-12Use the Automake variable nobase_dist_icons_DATArbuj14-193/+27
nobase_dist_icons_DATA: nobase: It tells that the files have same directory structure as the installed on system dist: It tells that the files should be included in the distribution tarball icons: It tells where to install the files DATA: It tells that they are data files, and they do not need to be compiled
2019-04-09Help: replace link linkend with xref linkendrbuj1-1/+1
Yelp viewer can't open cross-references to other parts of the manual using link linkend.
2019-04-02file-utils: avoid out of bound memory accessPablo Barciela1-1/+1
Fixes Clang static analyzer warning: file-utils.c:453:6: warning: Out of bound memory access (access exceeds upper limit of memory block) if (file_name [last_char] == G_DIR_SEPARATOR) ^~~~~~~~~~~~~~~~~~~~~
2019-04-02actions: avoid use of memory after it is freedPablo Barciela1-3/+3
Fixes Clang static analyzer warning: actions.c:137:5: warning: Use of memory after it is freed return full_uri; ^~~~~~~~~~~~~~~