summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2019-09-03Missing initializer for struct fieldrbuj26-28/+53
caja-engrampa.c:439:2: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘const struct _GTypeInfo’} [-Wmissing-field-initializers] eggtreemultidnd.c:70:2: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘const struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command.c:98:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-7z.c:750:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-ace.c:334:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-alz.c:397:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-ar.c:383:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-arj.c:429:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command.c:98:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-cfile.c:692:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-cpio.c:319:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-dpkg.c:305:17: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-iso.c:308:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-jar.c:234:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-lha.c:408:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-lrzip.c:262:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-rar.c:832:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-rpm.c:319:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-tar.c:1267:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-unarchiver.c:361:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-unstuff.c:381:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-zip.c:513:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-command-zoo.c:419:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-window.c:839:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] fr-list-model.c:148:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘const struct _GTypeInfo’} [-Wmissing-field-initializers] fr-process.c:248:3: warning: missing initializer for field ‘value_table’ of ‘GTypeInfo’ {aka ‘struct _GTypeInfo’} [-Wmissing-field-initializers] ui.h:32:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers] ui.h:33:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers] ui.h:34:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers] ui.h:35:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers] ui.h:36:2: warning: missing initializer for field ‘accelerator’ of ‘GtkActionEntry’ {aka ‘struct _GtkActionEntry’} [-Wmissing-field-initializers]
2019-09-03remove warnings: cast from function call [-Wbad-function-cast]rbuj3-4/+4
dlg-batch-add.c:513:83: warning: cast from function call of type ‘gint’ {aka ‘int’} to non-matching type ‘double’ [-Wbad-function-cast] 513 | gtk_spin_button_set_value (GTK_SPIN_BUTTON (GET_WIDGET ("a_volume_spinbutton")), (double) g_settings_get_int (data->settings, PREF_BATCH_ADD_VOLUME_SIZE) / MEGABYTE); | ^ dlg-new.c:321:81: warning: cast from function call of type ‘gint’ {aka ‘int’} to non-matching type ‘double’ [-Wbad-function-cast] 321 | gtk_spin_button_set_value (GTK_SPIN_BUTTON (data->n_volume_spinbutton), (double) g_settings_get_int (settings, PREF_BATCH_ADD_VOLUME_SIZE) / MEGABYTE); | ^
2019-09-03remove build warning: local variable shadows another variablerbuj3-10/+8
actions.c:245:24: warning: declaration of ‘dialog’ shadows a previous local [-Wshadow] caja-engrampa.c:137:17: warning: declaration of ‘file’ shadows a previous local [-Wshadow] caja-engrampa.c:58:17: warning: declaration of ‘file’ shadows a previous local [-Wshadow] dlg-add-files.c:120:9: warning: declaration of ‘uri’ shadows a previous local [-Wshadow] fr-window.c:4935:11: warning: declaration of ‘value’ shadows a previous local [-Wshadow]
2019-09-02java-utils: Remove blank spaces before reading package namerbuj1-3/+14
Closes https://github.com/mate-desktop/engrampa/issues/291 Test: touch test.txt zip test.zip test.txt mv test.zip test.jar cat << EOF > HelloWorld.java package org.mate.tests; class HelloWorld { public static void main(String args[]) { System.out.println("Hello, World"); } } EOF engrampa -a test.jar HelloWorld.java jar tf test.jar Output: test.txt org/mate/tests/HelloWorld.java
2019-09-02fr-command-lrzip: Fix empty string checkrbuj1-1/+1
str is empty: if (*str == '\0') {...}
2019-09-01Redundant redeclaration of ‘fr_command_is_capable_of’rbuj1-2/+0
fr-command.h:205:16: warning: redundant redeclaration of ‘fr_command_is_capable_of’ [-Wredundant-decls]
2019-09-01comparison of unsigned expression >= 0 is always truerbuj1-3/+4
java-utils.c:310:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 310 | for (i = length; (i >= 0) && (end == 0); i-- ) | ^~
2019-08-30gtk-utils: Remove unused wrapper for gtk_builder_new_from_filerbuj3-23/+0
Unused since https://github.com/mate-desktop/engrampa/commit/0d3a5b087f4bb6c118abe34a14ea27b86583f812
2019-08-29glib-genmarshal warning: BOOL token is deprecatedrbuj2-2/+2
2019-08-28comparison of integers of different signs: 'int' and 'guint'rbuj6-28/+28
Fix compiler warning: comparison of integers of different signs: 'int' and 'guint' (aka 'unsigned int') [-Wsign-compare]
2019-08-27glib-utils: Remove unused function - g_ptr_array_copyrbuj2-17/+0
closes https://github.com/mate-desktop/engrampa/issues/283
2019-08-26return sentence won't be never executed as it's preceded by exitrbuj1-2/+1
Detected by clang static analyzer: $ scan-build -enable-checker alpha.deadcode.UnreachableCode --keep-cc -o html-report make ... exit (EXIT_SUCCESS); return TRUE; /* <= This statement is never executed */ ...
2019-07-30Add zcompress supportSergey Ponomarev2-0/+25
2019-07-23fr-window: remove unused struct membersPablo Barciela1-2/+0
Fixes 'cppcheck' warnings: [src/fr-window.c:269]: (style) struct member '_FrWindowPrivateData::tree_hover_path' is never used. [src/fr-window.c:349]: (style) struct member '_FrWindowPrivateData::mitem_recents_menu' is never used.
2019-07-17fr-command-unarchiver: ask password if requiredPablo Barciela1-5/+9
2019-07-01Remove trailing whitespacesLaurent Napias17-121/+121
2019-06-11Update FSF addressLaurent Napias94-94/+94
2019-05-15Update ui.htamplan1-1/+1
Remove hard-coded 'Back' label button
2019-05-06Avoid deprecated g_type_class_add_privateWu Xiaotian1-7/+4
2019-04-02file-utils: avoid out of bound memory accessPablo Barciela1-1/+1
Fixes Clang static analyzer warning: file-utils.c:453:6: warning: Out of bound memory access (access exceeds upper limit of memory block) if (file_name [last_char] == G_DIR_SEPARATOR) ^~~~~~~~~~~~~~~~~~~~~
2019-04-02actions: avoid use of memory after it is freedPablo Barciela1-3/+3
Fixes Clang static analyzer warning: actions.c:137:5: warning: Use of memory after it is freed return full_uri; ^~~~~~~~~~~~~~~
2019-03-31fr-process: Fix memory leak: 'g_shell_quote' needs to be freedPablo Barciela1-3/+15
2019-03-31fr-process: Fix memory leak: 'g_strconcat' needs to be freedPablo Barciela1-12/+23
Use 'GString' instead 'g_strconcat'
2019-03-21[Security] fr-process: avoid 'strcpy' and 'strcat'Pablo Barciela1-16/+16
Use 'g_strlcpy' instead of 'strcpy', and 'g_strlcat' instead of 'strcat' Fixes Clang static analyzer warnings: fr-process.c:696:5: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 strcpy(rarfile, argv[2]); ^~~~~~ fr-process.c:698:5: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 strcat(rarfile, "part1.rar"); ^~~~~~ fr-process.c:705:32: warning: Out of bound memory access (accessed memory precedes memory block) rarfile[strlen(rarfile)-5]=0; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~
2019-03-14fr-process: Fix memory leakrbuj1-3/+1
Fixes Clang static analyzer warning: fr-process.c:740:3: warning: Potential leak of memory pointed to by 'argv' g_warning ("The files could not be move: %s\n", commandline); ^~~~~~~~~
2019-03-06Support .udeb package formatVictor Kareh3-6/+8
This enables support for udeb (micro-deb) files, which are a package format used during bootstrapping a Debian installation. They have the same mimetype as regular deb files.
2019-03-06Clean-up archive list and descriptionsVictor Kareh1-55/+55
2019-03-06Show version on command lineVictor Kareh1-0/+13
This adds a --version flag to the engrampa cli.
2019-02-20Avoid array index out of bounds parsing dpkg-deb --inforbuj1-2/+4
The first line of "dpkg-deb -I" output has only 5 words: old Debian package, version 0.939000. or new Debian package, version 2.0. Examples: $ wget http://archive.debian.org/debian/dists/Debian-0.93R6/binary/admin/acct-5-10.deb $ LANG=C dpkg-deb -I acct-5-10.deb old Debian package, version 0.939000. size 18338 bytes: control archive=1064, main archive=17260. 61 bytes, 3 lines conffiles 889 bytes, 20 lines control 570 bytes, 23 lines * postinst #!/bin/sh 107 bytes, 7 lines * postrm #!/bin/sh 212 bytes, 12 lines * preinst #!/bin/sh 212 bytes, 12 lines * prerm #!/bin/sh ... $ wget http://archive.debian.org/debian/dists/bo/main/binary-all/admin/alien_3.3.deb $ LANG=C dpkg-deb -I alien_3.3.deb new Debian package, version 2.0. size 20748 bytes: control archive=850 bytes. 394 bytes, 11 lines control 785 bytes, 13 lines md5sums
2019-02-20warning: Use of memory after it is freedrbuj1-1/+1
$ scan-build ./configure ... $ scan-build --keep-cc make ... fr-command-dpkg.c:76:23: warning: Use of memory after it is freed fdata->name = g_strdup (name); ^~~~~~~~~~~~~~~ ...
2019-02-19Read authors (updated) from engrampa.about gresourcerbuj7-10/+39
2019-01-08update copyright year to 2019Pablo Barciela1-1/+1
2019-01-03rar/unrar: Fix: "overwrite existing files" disabled must workPablo Barciela1-1/+1
Fixes https://github.com/mate-desktop/engrampa/issues/243
2018-12-28#225 fix a typoSergey Ponomarev1-1/+1
2018-12-28fix fr-command-cfile.c: fr_process_set_working_dirSergey Ponomarev1-1/+1
2018-12-28fr-command-cfile.c: fix indentationsponomarev1-61/+61
2018-12-28Added test integrity for brotlisponomarev1-0/+3
2018-12-28Added test integrity for the cfile compressors: gzip, bzip2, etc. But since ↵Sergey Ponomarev2-19/+60
most of them shows the message with file status to STDERR instead of STDOUT whe should show both in Test result window.
2018-12-11fr-window: show the pause button only if the dialog is workingPablo Barciela1-0/+3
2018-12-11fr-window: avoid 'gtk_dialog_add_button' with stock idsPablo Barciela1-3/+3
2018-12-08fr-window: hide the progress bar if the process is pausedPablo Barciela1-5/+7
2018-12-08fr-window: change the info label if process is paused/resumedPablo Barciela1-4/+9
2018-12-03fr-window: little improvements in the look of pause/resume buttonPablo Barciela1-6/+34
2018-12-02Adding pause and start functionszhuyaliang3-5/+98
change kill mode
2018-11-28Fix implementation and use of the alternative package nameIain Nicol1-5/+7
lookup Any real_name'' which was found was not getting used before. Also, when the lookup is unsuccessful, this means there is no /alternative/ package name. Thus we should use the hard-coded package name as the real_name for our PackageKit installation request. [bug #603757] origin commit: https://gitlab.gnome.org/GNOME/file-roller/commit/95aafc3c
2018-11-10Added support for brotli (*.tar.br) compressed tar archivesSergey Ponomarev2-0/+44
2018-10-30Add brotli supportSergey Ponomarev3-0/+25
2018-09-05fr-window: fix typoraveit651-1/+1
2018-08-22Add the ability to support 'unar' over .zip archivesPablo Barciela3-5/+28
Closes https://github.com/mate-desktop/engrampa/issues/210
2018-08-01Add support for OpenDocument formatsVictor Kareh2-1/+20
generated by cgit v1.2.1 (git 2.18.0) at 2024-11-04 16:37:20 +0000