Age | Commit message (Collapse) | Author | Files | Lines |
|
str is empty: if (*str == '\0') {...}
|
|
fr-command.h:205:16: warning: redundant redeclaration of ‘fr_command_is_capable_of’ [-Wredundant-decls]
|
|
java-utils.c:310:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
310 | for (i = length; (i >= 0) && (end == 0); i-- )
| ^~
|
|
Unused since https://github.com/mate-desktop/engrampa/commit/0d3a5b087f4bb6c118abe34a14ea27b86583f812
|
|
|
|
Fix compiler warning:
comparison of integers of different signs: 'int' and 'guint' (aka 'unsigned int') [-Wsign-compare]
|
|
closes https://github.com/mate-desktop/engrampa/issues/283
|
|
Detected by clang static analyzer:
$ scan-build -enable-checker alpha.deadcode.UnreachableCode --keep-cc -o html-report make
...
exit (EXIT_SUCCESS);
return TRUE; /* <= This statement is never executed */
...
|
|
|
|
Fixes 'cppcheck' warnings:
[src/fr-window.c:269]: (style) struct member '_FrWindowPrivateData::tree_hover_path' is never used.
[src/fr-window.c:349]: (style) struct member '_FrWindowPrivateData::mitem_recents_menu' is never used.
|
|
|
|
|
|
|
|
Remove hard-coded 'Back' label button
|
|
|
|
Fixes Clang static analyzer warning:
file-utils.c:453:6: warning: Out of bound memory access (access exceeds upper limit of memory block)
if (file_name [last_char] == G_DIR_SEPARATOR)
^~~~~~~~~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
actions.c:137:5: warning: Use of memory after it is freed
return full_uri;
^~~~~~~~~~~~~~~
|
|
|
|
Use 'GString' instead 'g_strconcat'
|
|
Use 'g_strlcpy' instead of 'strcpy', and 'g_strlcat' instead of 'strcat'
Fixes Clang static analyzer warnings:
fr-process.c:696:5: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
strcpy(rarfile, argv[2]);
^~~~~~
fr-process.c:698:5: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119
strcat(rarfile, "part1.rar");
^~~~~~
fr-process.c:705:32: warning: Out of bound memory access (accessed memory precedes memory block)
rarfile[strlen(rarfile)-5]=0;
~~~~~~~~~~~~~~~~~~~~~~~~~~^~
|
|
Fixes Clang static analyzer warning:
fr-process.c:740:3: warning: Potential leak of memory pointed to by 'argv'
g_warning ("The files could not be move: %s\n", commandline);
^~~~~~~~~
|
|
This enables support for udeb (micro-deb) files, which are a package format used during bootstrapping a Debian installation. They have the same mimetype as regular deb files.
|
|
|
|
This adds a --version flag to the engrampa cli.
|
|
The first line of "dpkg-deb -I" output has only 5 words:
old Debian package, version 0.939000.
or
new Debian package, version 2.0.
Examples:
$ wget http://archive.debian.org/debian/dists/Debian-0.93R6/binary/admin/acct-5-10.deb
$ LANG=C dpkg-deb -I acct-5-10.deb
old Debian package, version 0.939000.
size 18338 bytes: control archive=1064, main archive=17260.
61 bytes, 3 lines conffiles
889 bytes, 20 lines control
570 bytes, 23 lines * postinst #!/bin/sh
107 bytes, 7 lines * postrm #!/bin/sh
212 bytes, 12 lines * preinst #!/bin/sh
212 bytes, 12 lines * prerm #!/bin/sh
...
$ wget http://archive.debian.org/debian/dists/bo/main/binary-all/admin/alien_3.3.deb
$ LANG=C dpkg-deb -I alien_3.3.deb
new Debian package, version 2.0.
size 20748 bytes: control archive=850 bytes.
394 bytes, 11 lines control
785 bytes, 13 lines md5sums
|
|
$ scan-build ./configure
...
$ scan-build --keep-cc make
...
fr-command-dpkg.c:76:23: warning: Use of memory after it is freed
fdata->name = g_strdup (name);
^~~~~~~~~~~~~~~
...
|
|
|
|
|
|
Fixes https://github.com/mate-desktop/engrampa/issues/243
|
|
|
|
|
|
|
|
|
|
most of them shows the message with file status to STDERR instead of STDOUT whe should show both in Test result window.
|
|
|
|
|
|
|
|
|
|
|
|
change kill mode
|
|
lookup
Any real_name'' which was found was not getting used before.
Also, when the lookup is unsuccessful, this means there is no
/alternative/ package name. Thus we should use the hard-coded package
name as the real_name for our PackageKit installation request.
[bug #603757]
origin commit: https://gitlab.gnome.org/GNOME/file-roller/commit/95aafc3c
|
|
|
|
|
|
|
|
Closes https://github.com/mate-desktop/engrampa/issues/210
|
|
|
|
button by default
the Close button should be default so you can press Enter or Space without unintentionally opening the help manual
|
|
Fixes https://github.com/mate-desktop/engrampa/issues/198#issuecomment-394156805
|
|
|
|
taken from:
https://github.com/GNOME/file-roller/commit/ced6c25a93df7cc0ded59cc299a577441730faa3
|