summaryrefslogtreecommitdiff
path: root/src/core/xprops.c
diff options
context:
space:
mode:
authorPablo Barciela <[email protected]>2019-02-28 16:11:49 +0100
committerZenWalker <[email protected]>2019-03-05 01:51:32 +0100
commitfb920d7a52f755577ced7d9512b3fc5ec5ac83df (patch)
treed2023b9ff0aa60513c2923631b7778c38f3ae970 /src/core/xprops.c
parentc74c6115f6b5c0e1404440e40f433d87fb207ac1 (diff)
downloadmarco-fb920d7a52f755577ced7d9512b3fc5ec5ac83df.tar.bz2
marco-fb920d7a52f755577ced7d9512b3fc5ec5ac83df.tar.xz
[Security] Use 'g_strlcpy' instead of 'strcpy'
Fixes Clang static analyzer warnings: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
Diffstat (limited to 'src/core/xprops.c')
-rw-r--r--src/core/xprops.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/core/xprops.c b/src/core/xprops.c
index 03ec21e0..80dd7b59 100644
--- a/src/core/xprops.c
+++ b/src/core/xprops.c
@@ -821,7 +821,7 @@ class_hint_from_results (GetPropertyResults *results,
return FALSE;
}
- strcpy (class_hint->res_name, (char *)results->prop);
+ g_strlcpy (class_hint->res_name, (char *)results->prop, (len_name + 1));
if (len_name == (int) results->n_items)
len_name--;
@@ -837,7 +837,7 @@ class_hint_from_results (GetPropertyResults *results,
return FALSE;
}
- strcpy (class_hint->res_class, (char *)results->prop + len_name + 1);
+ g_strlcpy (class_hint->res_class, (char *)results->prop + len_name + 1, (len_class + 1));
XFree (results->prop);
results->prop = NULL;
@@ -1133,7 +1133,7 @@ meta_prop_get_values (MetaDisplay *display,
xmalloc_new_str = ag_Xmalloc (strlen (new_str) + 1);
if (xmalloc_new_str != NULL)
{
- strcpy (xmalloc_new_str, new_str);
+ g_strlcpy (xmalloc_new_str, new_str, (strlen (new_str) + 1));
meta_XFree (values[i].v.str);
values[i].v.str = xmalloc_new_str;
}