summaryrefslogtreecommitdiff
path: root/src/core
AgeCommit message (Collapse)AuthorFilesLines
2021-05-26window: Track window rectangle before tilingVictor Kareh1-1/+5
When tiling a maximized window, we should keep track of the saved rectangle so that tiling does not reset our window size. Otherwise, untiling the previously maximized window will end up with an unmaximized full-size window, rather than the original window size.
2021-04-30window: Only unmaximize when the window is already maximized.Zhiyi Zhang1-60/+64
When handling a ClientMessage event that removes _NET_WM_STATE_MAXIMIZED_HORZ or _NET_WM_STATE_MAXIMIZED_VERT from _NET_WM_STATE, marco always restore the window rectangle to the saved rectangle. So if an application window is already unmaximized and the application sends such a ClientMessage event, marco will reset the window rectangle regardless. EWMH doesn't specify what must be done when handling such events. It seems best to avoid restoring window rectangles like other window managers in this case. Fix a related bug: https://bugs.winehq.org/show_bug.cgi?id=50381 This revert a change introduced by 6219f8e8bcaeefb9185a3c3f5f20de4e2fa8f18f. Signed-off-by: Zhiyi Zhang <[email protected]>
2021-04-02window-props: g_memdup is dreprecated from glib 2.68rbuj1-2/+8
2021-03-29warning: declaration of a variable shadows a previous localrbuj1-4/+2
2021-03-18testasyncgetprop: Mismatching the argument type 'unsigned long'rbuj1-2/+2
and conversion specifier 'ld', reported by Apache NetBeans IDE
2021-03-18bell: Unused static function 'bell_flash_screen'rbuj1-0/+2
2021-03-08bell: missing include guardrbuj1-0/+5
2021-03-06i18n: Use glib's gettext support macrosrbuj14-1/+25
2021-03-01window: turn into a GObjectrbuj2-24/+54
2021-02-26Remove the copyright information when printing the version from the command linerbuj1-28/+4
2020-10-11Added VI keys (hjkl) for moving and resizing windowsKFB1-0/+20
2020-09-27window: do not unfocus on new window.rcaridade1451-17/+1
Fix keyboard input on fullscreen VLC. Based on Metacity commit https://gitlab.gnome.org/GNOME/metacity/-/commit/bf17c79
2020-08-18window: expand tile size cycling supportraveit653-1/+8
2020-08-04Remove multiple empty linesrbuj31-98/+0
find . \( -name '*.h' -o -name '*.c' \) -exec sed -i 'N;/^\n$/D;P;D;' {} \;
2020-08-04Remove trailing spaces/tabsrbuj11-81/+81
find . \( -name '*.h' -o -name '*.c' \) -exec sed -i 's/[[:space:]]*$//' {} \; find . \( -name '*.h' -o -name '*.c' \) -exec sed -i 's/\t*$//' {} \;
2020-05-27workspace: Don't try to use per-workspace MRU lists as a hint for focusingrcaridade1454-39/+17
A prior commit switched from focusing the topmost window as the default window to focusing the MRU window. This was done in alignment with the introduction of per-workspace MRU lists to avoid problems where the window stack was inadvertently changed when focusing windows during window switches. Now that focusing windows don't have as big an impact on the stacking order, we can revert back to focusing the top window, which is less confusing to the user. For now, leave per-workspace MRU lists, as they're a pretty good approximation of a global MRU list, and it works well enough. https://bugzilla.gnome.org/show_bug.cgi?id=620744 Based on commit https://gitlab.gnome.org/GNOME/metacity/-/commit/f628d8f8901f46fa9e00707ae9d7ccfd1e85f427
2020-05-27stack: make meta_window_raise() and meta_window_lower() smarterrcaridade1451-3/+39
https://bugzilla.gnome.org/show_bug.cgi?id=620744 Based on commit https://gitlab.gnome.org/GNOME/metacity/-/commit/9245f9588bd7c17ccbe04df65c1579313cbad07b
2020-05-27compositor: fix possible crash closing/destroying window . Fixes to previous ↵rcaridade1452-0/+14
commit. Partially restore call to destroy_win in compositor when calling meta_window_free. This is needed to ensure that we never call meta_window_get_frame_bounds while windows is destroying. https://bugzilla.gnome.org/show_bug.cgi?id=751833 Based on commit https://gitlab.gnome.org/GNOME/metacity/-/commit/a9f28dbc26f5211ef08889109db3dc8c7ba76aca
2020-05-27window: fix crash if workspace is nullrcaridade1451-1/+2
Based on commit https://gitlab.gnome.org/GNOME/metacity/-/commit/24d35569bdb78d1da3b53ed1a6d81d365d60bed0
2020-05-26Use rounded values instead of truncate themrbuj1-3/+4
If the decimal value is from .1 to .5, round(arg) returns the integer value less than the argument. Otherwise, if the decimal value is from .6 to .9, it returns the integer value greater than the arg.
2020-04-02Remove unnecessary warnings about visible regionVictor Kareh1-6/+7
Also reformat recent code change to fix styling issues.
2020-03-08Introduce nullpointer checks and return null if validation failsrcaridade1451-4/+7
2020-02-28util: meta_bug raises SIGABRT so it shouldn't returnrbuj1-1/+1
2020-02-21remove warning: 'GTimeVal' is deprecatedrbuj6-50/+34
2020-02-06window: handle legacy fullscreen requestsrcaridade1452-24/+30
https://gitlab.gnome.org/GNOME/metacity/commit/1fafd279006ece8cf664fd777143cdfafbefad6d window: handle legacy fullscreen requests Doing this on the actual resize requests makes more sense than handling it as a window-manager imposed constraints, so move the code accordingly. Adapted from mutter patch by Florian Müllner: https://git.gnome.org/browse/mutter/commit/?id=fba022cc06b8c7e80ef36f48d6577a251384cc4b https://bugzilla.gnome.org/show_bug.cgi?id=781946 Bug 781946 - Non-native decorated windows stuck maximised on secondary screen with Marco/Metacity
2020-02-04frame: remove unused variable 'status'rbuj1-1/+0
2020-01-22Xprops fix memory leak.rcaridade1451-7/+13
Origin commit : https://gitlab.gnome.org/GNOME/metacity/commit/c87f73f3b4413720a2f3e6a672826d3fec7f77a9 " XmbTextPropertyToTextList documentation says that XFreeStringList should be used to free the storage for the list and its contents. "
2019-10-31window: Add optional tile size cyclingVictor Kareh4-13/+116
Adding a new option to allow tile size cycling. When enabled, using the keyboard shortcut for tiling multiple times in a row cycles the window through different sizes (1/2 -> 1/3 -> 1/4 -> 3/4 -> 2/3 -> Untiled).
2019-10-27tabpopup: Render window thumbnail as cairo surfaceVictor Kareh1-81/+97
Instead of converting from surface to a GdkPixbuf and then back to a surface, we keep it as a surface for the entire manipulation flow. This improves rendering speed a bit and sets the ground for a higher resolution thumbnail in the future.
2019-10-27tabpopup: Draw transparent OSD-style popupsVictor Kareh2-2/+5
2019-09-24testboxes: Fix find_closest_point_to_line() testVictor Kareh1-4/+6
Eeeks, testing floating points for equality ... upstream commit: https://gitlab.gnome.org/GNOME/mutter/commit/0fccb0fc8
2019-09-19remove warnings: function declaration isn’t a prototyperbuj1-16/+16
core/testboxes.c:34:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:103:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:120:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:148:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:167:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:190:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:589:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:681:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:725:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:842:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:904:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:1021:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:1154:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:1243:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:1344:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes] core/testboxes.c:1396:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
2019-09-10Fix use of RBGA visual in frame.c when compositing is not in uselukefromdc1-37/+1
Use the window's visual in all cases, fix problems with drivers forcing use of blit rather than pageflip mode when comppositing is not used or window is unredirected Apply https://gitlab.gnome.org/GNOME/metacity/commit/5863176a2bd659c8d9a3d1c7b023a27c1a8c0aa5
2019-09-04window.c: remove unused variablePavel Shlyak1-3/+0
2019-08-31 display.c: add missing "break"Pavel Shlyak1-1/+1
2019-08-12async-getprop: Fix cast from non-struct type to struct typePablo Barciela1-1/+1
Fixes Clang static analyzer warning: core/async-getprop.c:277:11: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption reply = (xGetPropertyReply *) ^~~~~~~~~~~~~~~~~~~~~
2019-08-12xprops: Fix cast from non-struct type to struct typePablo Barciela1-2/+2
Fixes Clang static analyzer warnings: core/xprops.c:761:9: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption raw = (xPropWMHints*) results->prop; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ core/xprops.c:883:9: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption raw = (xPropSizeHints*) results->prop; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-08-10window: add _GTK_THEME_VARIANT to initial window propertiesmonsta1-1/+2
2019-08-02Fixed moving windows to edges to work with CSD clients.Omar Zeidan1-10/+13
2019-07-13window: Update allowed action hintsVictor Kareh1-7/+30
When changing window state, we want to change the allowed action hints so that other applications, mainly the taskbar, can disable menu entries that do not make much visual sense. For example, unmaximizing a minimized window: even though this operation is possible, it causes user confusion as there is no visibility until the user unminimizes it.
2019-06-07Make alt+tab max columns configurable and consider window label widthosch2-1/+39
2019-06-05update window->has_resize_func at the right time when unfullscreeningVictor Kareh1-3/+5
Since the frame window size that meta_window_move_resize() uses depends on whether the window has horizontal/vertical resize functionality, we need to update this flag before we resize the window. https://bugzilla.gnome.org/show_bug.cgi?id=659854 upstream commit: https://gitlab.gnome.org/GNOME/metacity/commit/c66d83a7
2019-06-05frame: remove uneeded includeVictor Kareh1-4/+0
upstream commit: https://gitlab.gnome.org/GNOME/metacity/commit/ca475d44
2019-06-05frame: make frame window transparentVictor Kareh1-6/+20
upstream commit: https://gitlab.gnome.org/GNOME/metacity/commit/74db1f11
2019-06-05frames: apply shapes in different wayVictor Kareh1-0/+24
upstream commit: https://gitlab.gnome.org/GNOME/metacity/commit/cd383e72
2019-06-05window: Correct coordinates for the configure eventVictor Kareh1-4/+8
We should still correct the coordinates for withdrawn windows. upstream commit: https://gitlab.gnome.org/GNOME/metacity/commit/9da3004e
2019-06-05frame: Make sure to offset by invisible borders when unmanaging windowsVictor Kareh1-2/+5
When we reparent a window to the root when we're exiting, we need to offset the position by the invisible borders, otherwise windows will creep up and to the left. https://bugzilla.gnome.org/show_bug.cgi?id=660848 upstream commit: https://gitlab.gnome.org/GNOME/metacity/commit/9fe51fd0
2019-06-05window: Fix _NET_FRAME_EXTENTS to work properlyVictor Kareh1-4/+7
_NET_FRAME_EXTENTS should contain the difference between where a window asked to be placed, and where it is. Ideally, this should be the same as the visible extents. https://bugzilla.gnome.org/show_bug.cgi?id=659848 upstream commit: https://gitlab.gnome.org/GNOME/metacity/commit/a3630d7c
2019-06-05window: Fix window placement to exclude invisible bordersVictor Kareh1-4/+4
A window can specify geometry that it is placed at. We need to exclude invisible borders when calculating where to place the window, otherwise the window will have a strange offset. https://bugzilla.gnome.org/show_bug.cgi?id=659848 upstream commit: https://gitlab.gnome.org/GNOME/metacity/commit/95373187
2019-06-05Account for invisible borders when constraining modal dialogsVictor Kareh1-1/+1
https://bugzilla.gnome.org/show_bug.cgi?id=656619 upstream commit: https://gitlab.gnome.org/GNOME/metacity/commit/4674358f
generated by cgit v1.2.1 (git 2.18.0) at 2024-12-29 02:14:35 +0000