Age | Commit message (Collapse) | Author | Files | Lines |
|
On subsequent changes, if there is a NET_WM_USER_TIME_WINDOW, then
read the property from that rather than from the main window.
(Fix an accidental regression: the right Window was being computed
but no longer passed in.)
Original patch author - Owen Taylor:
https://bugzilla.gnome.org/show_bug.cgi?id=585979
|
|
Basically it's odd to have "button_rect" be a function with all the
foo_rect GdkRectangles around - renaming to get_button_rect() will
free the name for the generically named "rect" once buttons are the
only movable pieces in the frame.
https://bugzilla.gnome.org/show_bug.cgi?id=741917
|
|
|
|
|
|
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=683056
|
|
When putting 32-bit properties into longs on 64-bit architectures,
XGetWindowProperty assumes the values are supposed to be signed, and
so it sign-extends values greater than 0x7fffffff. So if they *aren't*
supposed to be signed, we need to chop off the high bits ourselves.
(Most CARDINAL-valued properties only end up using small values
anyway, so it doesn't matter, but _NET_WM_WINDOW_OPACITY uses the full
range, and so was previously failing on 64-bit machines.)
https://bugzilla.gnome.org/show_bug.cgi?id=605678
|
|
Simplify the code by noting that when we have square end-caps, the
results of generic line path give the right pixel-aligned rectangle
for horizontal/vertical lines.
Add comments and remove some extra braces.
https://bugzilla.gnome.org/show_bug.cgi?id=630426
|
|
|
|
gtk_widget_set_uposition
|
|
|
|
|
|
|
|
Also drop the mate-desktop dark/light color functions in favour
of internal ones.
|
|
Since meta_workspace_invalidate_work_area() frees the edges
workspace->screen_edges and workspace->monitor_edges, we must clean up
our cached edge resistance data when the invalidate_work_area() is
called on the active workspace, or when the workspace changes.
Make the computation of the edge resistance data lazy so that it
will be recomputed the next time we try to access it.
meta_display_compute_resistance_and_snapping_edges() is made
private to edge-resistance.c
Invaliding the data when active workspace changes also will improve
correctness for edge resistance when the current workspace changes
during a grab operation. (Even with this fix we still don't try to
handle window positions changing during a grab operation; that can't
cause a crash since, unlike screen and monitor edges, the window edges
are freshly allocated, it will just cause slight oddness in that
corner case.)
Root cause tracked down due to much effort by Jon Nettleton.
https://bugzilla.gnome.org/show_bug.cgi?id=608800
|
|
be minimized (e.g. delete confirmation dialog, logout dialog...)
|
|
This fixes switching out of fullscreen Direct3D applications running in
Wine. See issue 166 for more details.
|
|
The theme state used to use GtkStateType, but was ported over to GtkStateFlags,
leaving behind a broken assertion that fails when using certain Metacity
themes, for example Nodoka.
https://bugzilla.gnome.org/show_bug.cgi?id=661286
https://git.gnome.org/browse/mutter/commit/?id=28deea4
https://git.gnome.org/browse/metacity/commit/?id=c9099b4
https://github.com/mate-desktop/marco/issues/205
|
|
tile preview: invalidate window before showing
|
|
Add tile keybinds (Fix #104, #127)
|
|
prefs: make workspace name actually change
|
|
prefs: make keybindings change notifications work with GLib >= 2.43
|
|
If this field is left uninitialized, a client may mistake Marco to support more than the single update request counter described in EWMH 1.5.
|
|
this is achieved by using the same GSettings instance for listening
and reading data. it's an additional fix for the issue with GLib >= 2.43,
https://git.gnome.org/browse/glib/commit/?id=8ff5668a458344da22d30491e3ce726d861b3619
|
|
now workspace names actually change on-the-fly when you change them in dconf-editor.
and this works with GLib 2.43 as well.
|
|
makes error dialogs on wrong command/terminal command actually work,
and fixes https://github.com/mate-desktop/marco/issues/150
Closes https://github.com/mate-desktop/marco/pull/185
Closes https://github.com/mate-desktop/marco/issues/150
|
|
from https://git.gnome.org/browse/metacity/commit/?id=5f8df557b8dbe962f19e8b641c007073665ff878
Closes https://github.com/mate-desktop/marco/pull/178
|
|
fixes the issue with GLib >= 2.43,
https://git.gnome.org/browse/glib/commit/?id=8ff5668a458344da22d30491e3ce726d861b3619
Closes https://github.com/mate-desktop/marco/pull/174
|
|
|
|
|
|
|
|
has_maximize_func implies
window->has_resize_func
!window->fullscreen
window->has_resize_func implies
(window->size_hints.min_width < window->size_hints.max_width) ||
(window->size_hints.min_height < window->size_hints.max_height)
A tiled window implies that it could be tiled.
A maximized window implies that it could be tiled.
.
Therefore simplify the if and add window->shaded to make it equivalent to the
macro but allowing to tile already maximized/tiled windows.
.
If this commit causes a regression it probably means that a call to
meta_window_recalc_features is missing.
.
This bug already existed but can only be triggered by the new keybindings.
|
|
The removed code did not allow tiled windows to be unmaximized. The code was
trying to retile a tiled window when it was asked to unmaximize it. The only
thing it did was turn a maximized window into a tiled window but that is not
the normal expected behaviour of unmaximization.
.
I also reset window->tile_mode to ensure we always unmaximize correctly.
Some duplicate code was also removed.
.
This bug affects tiling with:
- tile-to-side-w
- tile-to-side-e
- Mouse dragging to the west corner
- Mouse dragging to the east corner
.
Therefore it's an old bug unrelated to the new keybindings.
|
|
These are the minimal changes needed to make the keybinds work. Anything
else should be fixed outside handle_toggle_tiled.
|
|
This is just a copy/paste from move-to-side-{e,w} with:
s/move/tile/g
s/Move/Tile/g
.
It uses the existing handle_toggle_tiled as the backend.
|
|
|
|
Closes https://github.com/mate-desktop/marco/pull/152
|
|
Closes https://github.com/mate-desktop/marco/pull/145
|
|
Closes https://github.com/mate-desktop/marco/pull/144
|
|
merge metacity(gtk3) changes
fix warnings
clean up unused variables
replace UNUSED_VARIABLE by G_GNUC_UNUSED
|
|
|
|
|
|
Closes https://github.com/mate-desktop/marco/issues/149
|
|
GTK+ has now started using _NET_WM_STATE_HIDDEN for iconified windows.
For windows iconified at creation time, this causes metacity to set
minimize_after_placement, which then causes the window to become
minimized immediately after the first time it has been activated by
the user.
This happens because:
(1) minimize_after_placement is reset after placing the window
(2) if a window is minimized, placement is deferred
Reset minimize_after_placement unconditionally in place_window_if_needed()
to solve the issue.
Reported and tested by Daniel Drake <[email protected]>
Based on metacity commit: b0700e20b79896de7d28d2ff2bb18be324d8e19f
From: Florian Müllner <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=684741
|
|
XLib has historically used "char*" for "generic pointer" but
compliers rightly complain when casting this to a structure.
Work around this by casting to void * and letting the implicit
conversion to a structure type take effect.
Based on metacity commit: 687376bb549b3d60ba848c9d4105fe41087f3a77
From: Colin Walters <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=611644
|
|
While the configured layout is taken into account for positioning
the buttons, the mapping from button function states to button
position states just assumed the default button layout in LTR
locales.
Do a proper mapping depending on the actual layout instead.
Based on metacity commit: 6a52883c2b670ad645257373515d1e704408b93d
From: Florian Müllner <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=638700
|
|
This patch fixes the drawing of <arc> theme elements to appear in the desired orientation
Based on metacity commit: 120c7790d6c5a837372ef1e0105e89ac674facd8
From: Nickolas Lloyd <[email protected]>
|
|
Simplify the keymap loading logic by unifying the different
branches; in the reorganization this patch fixes a bug where when
we got a MappingKeyboard event we wouldn't update virtual modifiers
correctly.
Based on a patch by Thomas Thurman <[email protected]>
Based on metacity commit: ba2e5f7f541446931299814bafa642d09047f386
From: "Owen W. Taylor" <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=565540
|
|
* Select for XKB keyboard notification events explicitly; since GTK+
has selected for XKB events, delivery of old-school MappingNotify
events is disabled.
* Fix a bug where once a keycode was loaded for a key binding,
it would never be reassigned; we want to laod new keycodes for
all bindings that have a key symbol rather than a fixed
keycode.
[ With fixes from Owen W. Taylor <[email protected]> ]
Based on metacity commit: c262e3d65a37abedc507705cddfec72c901c321f
From: Derek Poon <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=565540
|
|
We currently allow XRaiseWindow when the same application (defined
by the window group) is focused, but the kind of old applications
that XRaiseWindow are frequently not setting the window group.
Expand the check to allow the same X client (defined by the looking
at client ID) to raise windows above the focus window.
Based on metacity commit: 632d3983fbc402432c6ceae05bea8903ad2f11c0
From: "Owen W. Taylor" <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=567528
|
|
This reverts commit 69b7a0ad9277f21ad761c84ac1bae5455a2f879e.
It has the unintended side-effect that it reverses the alt+tab
behaviour.
|