summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrbuj <[email protected]>2019-03-11 20:38:49 +0100
committerZenWalker <[email protected]>2019-04-19 23:00:12 +0200
commit186fca07c5bbdde4e208e019090724dd938400b8 (patch)
treee3f590be983557f197d9c27e7a1de37090355aae
parent00147636737d36b4b05f54a6f64f854932767129 (diff)
downloadmate-control-center-186fca07c5bbdde4e208e019090724dd938400b8.tar.bz2
mate-control-center-186fca07c5bbdde4e208e019090724dd938400b8.tar.xz
control-center: Fix memory leak
Reported by clang: control-center.c:84:2: warning: Potential leak of memory pointed to by 'action' g_slist_free(key_list); ^~~~~~~~~~~~
-rw-r--r--libslab/app-shell.h2
-rw-r--r--shell/control-center.c2
2 files changed, 3 insertions, 1 deletions
diff --git a/libslab/app-shell.h b/libslab/app-shell.h
index 6b968763..9db7a9d1 100644
--- a/libslab/app-shell.h
+++ b/libslab/app-shell.h
@@ -112,7 +112,7 @@ typedef struct
typedef struct
{
- const gchar *name;
+ gchar *name;
MateDesktopItem *item;
} AppAction;
diff --git a/shell/control-center.c b/shell/control-center.c
index 55c4246d..20d2012b 100644
--- a/shell/control-center.c
+++ b/shell/control-center.c
@@ -70,6 +70,8 @@ static GSList* get_actions_list(void)
if ((action->item = load_desktop_item_from_unknown(temp[1])) == NULL)
{
+ g_free (action->name);
+ g_free (action);
g_warning("get_actions_list() - PROBLEM - Can't load %s\n", temp[1]);
}
else