summaryrefslogtreecommitdiff
path: root/libmate-desktop/mate-desktop-thumbnail.c
AgeCommit message (Collapse)AuthorFilesLines
2020-01-18thumbnail: Remove obsolete mate_desktop_thumbnail_md5()Bastien Nocera1-20/+0
https://bugzilla.gnome.org/show_bug.cgi?id=785198 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/8663695
2020-01-18thumbnail: Use an array to store the thumbnailer's cmdlineBastien Nocera1-48/+104
Instead of a shell-quoted string, to make it easier to add new elements to this command-line. origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/483ea2e
2020-01-18thumbnail: Use g_strcmp0() and remove a NULL checkBastien Nocera1-7/+2
origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/a5188e5
2020-01-18thumbnail: Simplify system includesBastien Nocera1-12/+3
origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/1c9cabf
2020-01-18thumbnail: Fix typo in optionalBastien Nocera1-1/+1
origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/fdb6fd1
2020-01-18thumbnail: Remove unused constant SECONDS_BETWEEN_STATSBastien Nocera1-2/+0
2020-01-18thumbnail: Remove unused #define GDK_PIXBUF_ENABLE_BACKENDBastien Nocera1-1/+0
origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/b025840
2020-01-18thumbnail: Remove reference to MateIconFactoryBastien Nocera1-1/+1
origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/a63a558
2020-01-18thumbnail: Simplify init_thumbnailers_dirs()Bastien Nocera1-9/+8
origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/a0702a2
2020-01-09thumbnail: some code-styling fixesraveit651-79/+76
- replace remaining tabs with spaces - fixes some indents
2020-01-09thumbnailer: Always prefer the backend provided previewBastien Nocera1-2/+64
If a preview exists for a particular file, in particular a preview icon for videos and images on external devices, prefer those to running a script. https://bugzilla.gnome.org/show_bug.cgi?id=738503 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/370b985 https://gitlab.gnome.org/GNOME/gnome-desktop/commit/e629e46 https://gitlab.gnome.org/GNOME/gnome-desktop/commit/a15db1d https://gitlab.gnome.org/GNOME/gnome-desktop/commit/fc19c94
2020-01-09thumbnail: Always use external gdk-pixbuf thumbnailerBastien Nocera1-359/+3
Instead of special-casing gdk-pixbuf-supported image formats, use an external thumbnailer. This will give us the ability to: - cancel running thumbnail operations - avoid memory leaks, buffer overflows, double-frees, etc. in the image loaders having an impact on the application - limit resource usage when thumbnailing https://bugzilla.gnome.org/show_bug.cgi?id=768064 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/b69fde6 https://gitlab.gnome.org/GNOME/gnome-desktop/commit/dba6d95
2020-01-09thumbnail: Demote a log message from WARNING to DEBUGraveit651-1/+1
Failure to create a GdkPixbufLoader for a specific MIME type doesn't necessarily indicate an error. It is possible that the fallback code would still be able to parse the image data. For example, Canon CR2 RAW files have the MIME type image/x-canon-cr2. While we don't have a loader for that specific MIME type, the TIFF loader can still parse the data. In case the fallback code failed to parse the image data, we get a WARNING anyway: MateDesktop-WARNING **: Error creating thumbnail for ... Having a log message to indicate that we are using the fallback code is useful for debugging, but there is no need for the WARNING. It can be extra noise and needlessly interferes with things like G_DEBUG=fatal-warnings. https://bugzilla.gnome.org/show_bug.cgi?id=762504 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/7507254
2020-01-09thumbnail factory: Disconnect signal handlers in finalizeMatthias Clasen1-46/+43
We are seeing crashes in Fedora that point at the settings signal handlers getting run after the thumbnail factory is finalized. Explicitly disconnecting the handlers in finalize is the right thing to do, anyway. While we are at it, replace some of the cleanup code in finalize with g_clear_pointer and g_clear_object, as suggested by Colin. https://bugzilla.gnome.org/show_bug.cgi?id=761049 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/f32c389
2020-01-09thumbnail: Move thumbnail generation/saving to a few helperJasper St. Pierre1-203/+127
functions Another cleanup in preparation for a new "simple" thumbnail API. https://bugzilla.gnome.org/show_bug.cgi?id=684026 https://bugzilla.gnome.org/show_bug.cgi?id=784915 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/97f6f77 https://gitlab.gnome.org/GNOME/gnome-desktop/commit/ef4734f https://gitlab.gnome.org/GNOME/gnome-desktop/commit/911091d
2020-01-09thumbnail: Clean up path generation codeJasper St. Pierre1-100/+66
Put the path calculation code in one spot. https://bugzilla.gnome.org/show_bug.cgi?id=684026 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/57c18b8 https://gitlab.gnome.org/GNOME/gnome-desktop/commit/ef0f02e
2020-01-09thumbnailer: Try harder to create a failed thumbnailJuan Antonio Marin1-13/+9
If a failed thumbnail is created because the pixbuf fail to save (for instance if user is over quota) we should still try to rename the temporary file that might have been created. If not, the thumbnail will not be marked as failed, and thumbnailing will be reattempted. https://bugzilla.gnome.org/show_bug.cgi?id=728775 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/54f68ab
2020-01-09Add missing cases to switch statementPhilip Withnall1-41/+103
This shuts up a gcc warning by adding support for thumbnail directories being unmounted or moved. https://bugzilla.gnome.org/show_bug.cgi?id=709819 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/c064fab
2019-12-08avoid redundant redeclarationsPablo Barciela1-3/+1
2019-10-31Treat time_t as gint64 to convert from/to stringOBATA Akio1-5/+7
"time_t" may not equal with "long", especiall 32-bit platforms resolved "Year 2038 problem". There are no standard way to convert time_t from/to string, but GLib2 using gint64 type as a time internally, so it is reasonable to use gint64 for such purpose.
2019-07-03Remove trailing whitespacesLaurent Napias1-41/+41
2019-03-25mate-desktop-thumbnail: avoid 'NULL' parameterPablo Barciela1-1/+1
Fixes Clang static analyzer warning: mate-desktop-thumbnail.c:933:54: warning: Null pointer passed as an argument to a 'nonnull' parameter g_checksum_update (checksum, (const guchar *) uri, strlen (uri)); ^~~~~~~~~~~~
2019-01-29Improve indentsWu Xiaotian1-2/+2
2019-01-29Avoid deprecated g_type_class_add_privateWu Xiaotian1-7/+2
Changed MateBgCrossfade, MateColorbutton and MateDesktopThumbnail
2015-10-26thumbnail: Fix a code path where the mutex is never unlockedmonsta1-4/+5
ported from https://git.gnome.org/browse/gnome-desktop/commit/?id=5b28350d3229d36d7c64084e52f5a40ee5903723
2015-07-03backport cinnamon-desktop fix for buggy image typesleigh123linux1-32/+54
2015-03-13mate-thumbnail: first connect to settings, then read them.Monsta1-3/+6
fixes the issue with GLib >= 2.43, https://git.gnome.org/browse/glib/commit/?id=8ff5668a458344da22d30491e3ce726d861b3619 Closes https://github.com/mate-desktop/mate-desktop/pull/162
2014-12-16Revert "Revert "Drop support for Glib < 2.36""infirit1-99/+0
This reverts commit a0a0a16fb72bb7b592d23ce29ca52c7d63c2e40b.
2014-12-16Revert "Drop support for Glib < 2.32"infirit1-0/+64
This reverts commit 82d352cb10ed140b618b2c00a3935a3e8c6d1ba0.
2014-12-16Drop support for Glib < 2.32infirit1-64/+0
2014-12-16Revert "Drop support for Glib < 2.36"infirit1-0/+99
This reverts commit 6a0c8a93e30243232d63487c09ccb15a93755265.
2014-11-28Add support for GObjectIntrospectioninfirit1-1/+1
Turned all GnomeRR structures into boxed types, then added the needed annotations and the Makefile.am bits. Does not yet include API changes, but should bind (awfully) all of libgnome-desktop. Based on gnome commit: cad94246fb5be76482212407a380cd75f9e7b932 url: https://git.gnome.org/browse/gnome-desktop/commit/?id=cad94246fb5be76482212407a380cd75f9e7b932
2014-11-28avoid dereferencing NULL pointerMonsta1-4/+2
Closes https://github.com/mate-desktop/mate-desktop/pull/145
2014-06-05Drop support for Glib < 2.36infirit1-99/+0
2013-07-24Move include files and remove old libmate and libmateui foldersStefano Karapetsas1-1/+1
2013-02-20Don't thumbnail thumbnails in .cache/thumbnailsStefano Karapetsas1-1/+2
2012-11-02fix thumbnails path for glib >= 2.34Stefano Karapetsas1-14/+28
2012-10-15add retro-compatibility for glib < 2.31Stefano Karapetsas1-1/+65
2012-09-12remove unused includeStefano Karapetsas1-1/+0
2012-09-07fix thumbnails factoryStefano Karapetsas1-47/+50
on nautilus, thumbnail path is set by g_file_info_get_attribute_byte_string (info, G_FILE_ATTRIBUTE_THUMBNAIL_PATH); but this gives path in ~/.thumbnails, not ~/.cache/thumbnails, so revert to the old location
2012-09-06fix gsettings schema nameStefano Karapetsas1-1/+1
2012-09-03update to latest thumbnail spec (code taken from gnome-desktop)Stefano Karapetsas1-270/+652
2011-12-01moving from https://github.com/perberos/mate-desktop-environmentPerberos1-0/+1302