summaryrefslogtreecommitdiff
path: root/libmate-desktop
AgeCommit message (Collapse)AuthorFilesLines
2020-02-16thumbnail: Demote a log message from WARNING to DEBUGraveit651-1/+1
Failure to create a GdkPixbufLoader for a specific MIME type doesn't necessarily indicate an error. It is possible that the fallback code would still be able to parse the image data. For example, Canon CR2 RAW files have the MIME type image/x-canon-cr2. While we don't have a loader for that specific MIME type, the TIFF loader can still parse the data. In case the fallback code failed to parse the image data, we get a WARNING anyway: MateDesktop-WARNING **: Error creating thumbnail for ... Having a log message to indicate that we are using the fallback code is useful for debugging, but there is no need for the WARNING. It can be extra noise and needlessly interferes with things like G_DEBUG=fatal-warnings. https://bugzilla.gnome.org/show_bug.cgi?id=762504 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/7507254
2020-02-16thumbnail factory: Disconnect signal handlers in finalizeMatthias Clasen1-46/+43
We are seeing crashes in Fedora that point at the settings signal handlers getting run after the thumbnail factory is finalized. Explicitly disconnecting the handlers in finalize is the right thing to do, anyway. While we are at it, replace some of the cleanup code in finalize with g_clear_pointer and g_clear_object, as suggested by Colin. https://bugzilla.gnome.org/show_bug.cgi?id=761049 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/f32c389
2020-02-16thumbnailer: Try harder to create a failed thumbnailJuan Antonio Marin1-13/+9
If a failed thumbnail is created because the pixbuf fail to save (for instance if user is over quota) we should still try to rename the temporary file that might have been created. If not, the thumbnail will not be marked as failed, and thumbnailing will be reattempted. https://bugzilla.gnome.org/show_bug.cgi?id=728775 origin commit: https://gitlab.gnome.org/GNOME/gnome-desktop/commit/54f68ab
2020-02-16Treat time_t as gint64 to convert from/to stringOBATA Akio1-5/+7
"time_t" may not equal with "long", especiall 32-bit platforms resolved "Year 2038 problem". There are no standard way to convert time_t from/to string, but GLib2 using gint64 type as a time internally, so it is reasonable to use gint64 for such purpose.
2019-03-25mate-thumbnail-pixbuf-utils: Fix division by zeroPablo Barciela1-3/+9
Fixes Clang static analyzer warning: mate-thumbnail-pixbuf-utils.c:160:17: warning: Division by zero *dest++ = r / n_pixels; ~~^~~~~~~~~~
2019-03-25mate-bg: Fix memory leakPablo Barciela1-0/+2
Fixes Clang static analyzer warning: mate-bg.c:2764:2: warning: Potential leak of memory pointed to by 'size' g_queue_push_tail (parser->stack, g_strdup (name)); ^~~~~~~~~~~~~~~~~
2019-03-17[Security] Use 'g_strlcpy' instead of 'strcpy'Pablo Barciela2-2/+2
Fixes Clang static analyzer warnings: mate-rr-config.c:549:3: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 strcpy (output->priv->vendor, "???"); ^~~~~~ mate-desktop-item.c:2118:2: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 strcpy (the_exec, exec); ^~~~~~
2019-03-17[Security] test-ditem: Use 'g_strlcat' instead of 'strcat'Pablo Barciela1-1/+1
Fixes Clang static analyzer warning: test-ditem.c:94:2: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 strcat (path, "/foo.desktop"); ^~~~~~
2019-02-07mate-colorsel: avoid deprecated 'gtk_widget_modify_bg'Pablo Barciela1-5/+26
2019-01-29[mate-rr] Avoid deprecated g_type_class_add_privateWu Xiaotian4-15/+9
2019-01-29Improve indentsWu Xiaotian1-2/+2
2019-01-29Avoid deprecated g_type_class_add_privateWu Xiaotian3-20/+6
Changed MateBgCrossfade, MateColorbutton and MateDesktopThumbnail
2019-01-29[mate-colorsel] Avoid deprecated g_type_class_add_privateWu Xiaotian2-51/+49
2019-01-09mate-bg: avoid deprecated 'g_settings_list_keys'Pablo Barciela1-3/+7
2018-12-12mate-bg: Corrected some commentsZhang Xianwei1-3/+3
There are some incorrect comments in mate_bg_create_surface_scale. Fix them. Signed-off-by: Zhang Xianwei <[email protected]>
2018-08-15mate-desktop-item: replace deprecated gdk_error_trap_push/popraveit651-2/+8
2018-08-15mate-rr-config: replace deprecated gdk_flushraveit651-1/+3
2018-08-15mate-rr: replace deprecated Gdk functionsraveit651-13/+23
2018-08-15mate-bg-crossfade: replace deprecated gdk_error_trap_push/popraveit651-4/+6
2018-08-15mate-bg: replace deprecated gdk_error_trap_push/popraveit651-4/+8
2018-07-03add mate-language apisyetist3-0/+1352
2018-04-25Support background fallback on HiDPIVictor Kareh2-2/+43
This change is a super hacky way of supporting the fallback desktop background (without caja) on HiDPI displays. It does this by doing two things: providing a function for scaled-up background surfaces using cairo_scale; and triggering a change signal when the entire background schema is re-loaded, and so triggering a redraw.
2018-03-30mate-rr-labeler: fix font-color for dark themesraveit651-3/+3
Fixes https://github.com/ubuntu-mate/ubuntu-mate-artwork/issues/29
2018-01-27building: remove < gtk+-3.22 bits and bump required gtk+ versionraveit655-63/+1
2017-12-17WidthOfScreen and HeightOfScreen implementationPablo Barciela3-18/+9
This commit reverts: https://github.com/mate-desktop/mate-desktop/commit/6137212bce120c9eb5555ae777fc7fea2f71e43e And it applies an alternative to fix the deprecated functions: gdk_screen_get_width gdk_screen_get_height
2017-08-26drop MateAboutDialogmonsta3-2430/+0
2017-08-17gtk 3.22: avoid deprecated gdk_screen_get_monitor... functions:ZenWalker2-0/+17
avoid deprecated: gdk_screen_get_monitor_geometry gdk_screen_get_monitor_at_point
2017-08-16avoid deprecated gdk_screen_get_width/heightZenWalker3-8/+18
2017-08-10mate-desktop-item: mate-about: avoid deprecated gtk_show_uriraveit651-0/+7
2017-08-10mate-about: avoid deprecated gtk_show_uriraveit651-0/+6
2017-08-05avoid deprecated gdk_screen_get_n_monitorsZenWalker1-0/+15
2017-08-05avoid deprecated gdk_screen_make_display_nameZenWalker1-6/+8
2017-08-05avoid deprecated gdk_screen_get_numberZenWalker2-8/+8
2017-05-05Fix broken fallback cursor in mate-colorsel.cnokangaroo1-40/+31
2017-04-27mate-colorsel: don't use deprecated GTK_STOCK_COLOR_PICKERraveit651-1/+1
2017-03-13mate-aboutdialog: Fix url is not centeredLa Ode Muh. Fadlun Akbar1-1/+1
2017-03-12Avoid deprecated gdk_window_set_background functionsAlexei Sorokin3-54/+244
Allows to fix backgrounds in Caja and fixes fading. These changes somewhat break API behavior.
2017-02-25mate-bg: force property update when doing new crossfade frameRay Strode1-0/+15
marco needs to get notified about animation updates. This commit frobs the property to wake marco up. https://bugzilla.gnome.org/show_bug.cgi?id=641526
2017-02-10colorsel: port to GtkGridraveit651-30/+31
2017-02-02mate-bg: Fix solid colorsAlexei Sorokin1-3/+3
2017-02-02mate-bg: Avoid possible X11 data leaksAlexei Sorokin1-13/+23
2016-11-20move to GTK+3 (>= 3.14), drop GTK+2 code and --with-gtk build optionmonsta18-689/+4
2016-11-20fix indent a bitmonsta1-3/+3
2016-11-20remove obsolete lib from mate-desktop-2.0-uninstalled.pc.inmonsta1-1/+1
not sure if anyone actually uses it though...
2016-10-18GTK+-2: fix fontcolor for dark bg in cajaraveit651-0/+6
Fixes https://github.com/mate-desktop/mate-desktop/issues/237
2016-07-02GTK+-3 mate-bg: fix gradiant color creationraveit651-0/+6
credits to Alexei Sorokin
2016-07-02GTK+-3 mate-bg: Don't use C99 declarationsraveit651-4/+5
It's not really necessary. taken from: https://git.gnome.org/browse/gnome-desktop/commit/?h=gnome-3-6&id=2738c5c
2016-07-02GTK+-3 mate-bg: have pixbuf_average_value return GdkRGBAraveit651-0/+33
Now that we have a proper type for RGBA values, we should use it (instead of packing the four components into a uint32). https://bugzilla.gnome.org/show_bug.cgi?id=671750 taken from: https://git.gnome.org/browse/gnome-desktop/commit/?h=gnome-3-4&id=0f60413
2016-07-02GTK+-3 mate-bg-crossfade: port to GtkStyleContextraveit651-0/+12
with help from Alexei Sorokin
2016-07-02GTK+3 mate-bg: port GdkColor to GdkRGBAraveit652-4/+91