| Age | Commit message (Collapse) | Author | Files | Lines |
|
When a notification is removed from the hash table, any pending idle
reposition source must be explicitly canceled in to avoid attempting to
remove an already-removed source.
This prevents the race condition where the timeout fires and
auto-removes itself before the notification cleanup tries to cancel it.
|
|
Prevent daemon from exiting when history tracking is enabled to preserve
the in-memory notification history.
|
|
Add destroy notify callback to prevent use-after-free crashes when
notifications are closed before their reposition timeout fires.
Fixes #236
|
|
Add checks for monitor_id to prevent crash during monitor change events.
Instead it falls back to last available monitor and allows notification
processing to continue without a monitor.
Fixes: #200
|
|
This helps a bit with privacy. By disabling history, it wipes all
notifications in the D-Bus buffer and prevents further storage. The
history popup is also disabled.
Notification storage resumes when history is enabled.
Note that this just prevents the mate-notifications-daemon from storing
notifications, but it doesn't prevent other processes from capturing
them elsewhere.
|
|
Added a circular buffer for tracking notifications in dbus, and methods
for accessing those notifications. The idea is to implement a proper
notifications system.
|
|
Recent versions of libwnck introduced a WnckHandler object to be used as
the main entry point into the library.
|
|
Add persistence support with resident/transient hints, fix icon
precedence order (according to spec), and implement desktop-entry icons.
Also added new 'default-timeout' and 'enable-persistence' gsettings to
allow users to control timeout and persistence behavior.
Spec is on https://specifications.freedesktop.org/notification-spec/1.3/
Fixes https://github.com/mate-desktop/mate-notification-daemon/issues/132
Fixes https://github.com/mate-desktop/mate-notification-daemon/issues/137
Fixes https://github.com/mate-desktop/mate-notification-daemon/issues/138
Fixes https://github.com/mate-desktop/mate-notification-daemon/issues/149
|
|
Returning an error for a dbus method is counted as handling a method invocation. Return true in the handler to avoid a use-after-free.
|
|
remove exit / replace with gtk_main_quit
[ 7590.265881] mate-notificati[76519]: segfault at 55ac5111c67a ip 00007d1d4fc09d61 sp 00007ffd0bf06698 error 4 in libgobject-2.0.so.0.8000.0[7d1d4fbdc000+37000] likely on CPU 0 (core 0, socket 0)
[ 7590.265910] Code: 01 00 00 00 4c 89 ce 48 89 e5 e8 da e6 ff ff 5d 85 c0 0f 95 c0 0f b6 c0 c3 f3 0f 1e fa 48 85 ff 74 47 48 8b 07 48 85 c0 74 3f <48> 8b 00 48 3d fc 03 00 00 77 2c 48 8d 15 cd 53 02 00 48 c1 e8 02
|
|
Fixes #218.
|
|
|
|
This allows to run as a regular session service that does not exit, but
also as a well-behaved D-Bus-activated service. Make the default
behavior not to exit, but when activated through D-Bus.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
not GObjects)]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
g_variant_lookup works like g_variant_get, so using a format string of "v" only
works if the type is actually a GVariant. Since none of the hints have GVariant
values, that means every g_variant_get with a "v" format will fail.
Fix all of the g_variant_lookup calls so that they either unpack a value
directly, or use a "@" prefix when it's more convenient to fetch the value as
a GVariant pointer.
In addition, in cases where we do fetch a GVariant, make sure that we
unreference it afterward.
|
|
|
|
|
|
- src/daemon/daemon.c
- src/daemon/daemon.h
|
|
|
|
|
|
libglib2.0-bin.
|
|
and drop additional checks for min/max GLib versions, it's not needed
|
|
avoid deprecated:
gdk_screen_get_monitor_geometry
gdk_screen_get_monitor_at_point
|
|
|
|
|
|
Fix #117
|
|
The freedesktop specification states that clients may opt to use named icons
instead of textual labels on action buttons. In this instance, the icon name
is passed as the 'key' (actions[i+1]) element in the actions data passed
to the daemon.
For themes to render the icon, they should check the hints passed by the
client for a boolean value of "action-icons", and if it is set they should
then create an image button based on the key, and not the label.
Many applications now make use of action-icons, such as media players, to
provide self describing actions with well known icon names, such as playback
controls. In the absence of support for action-icons they fallback to less
useful buttons and generally less actions.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
|
|
By using a bit, rather than a byte for gbooleans.
https://bugzilla.gnome.org/show_bug.cgi?id=622556
taken from:
https://git.gnome.org/browse/notification-daemon/commit/?id=c43d398
|
|
|
|
|
|
This reverts commit 7d162d83a2008c25b3134fcdda8265f23d461585.
fixes https://github.com/mate-desktop/mate-notification-daemon/issues/91
|
|
GTK3 daemon: fix deprecated gdk_display_get_pointer
|
|
inspired from:
https://git.gnome.org/browse/notification-daemon/patch/?id=9f376d3
|
|
GValueArray is deprecated so move to GArray instead in
_notify_daemon_pixbuf_from_data_hint()
|