Age | Commit message (Collapse) | Author | Files | Lines |
|
g_variant_lookup works like g_variant_get, so using a format string of "v" only
works if the type is actually a GVariant. Since none of the hints have GVariant
values, that means every g_variant_get with a "v" format will fail.
Fix all of the g_variant_lookup calls so that they either unpack a value
directly, or use a "@" prefix when it's more convenient to fetch the value as
a GVariant pointer.
In addition, in cases where we do fetch a GVariant, make sure that we
unreference it afterward.
|
|
|
|
|
|
|
|
|
|
- src/daemon/daemon.c
- src/daemon/daemon.h
|
|
|
|
|
|
|
|
|
|
|
|
|
|
libglib2.0-bin.
|
|
and drop additional checks for min/max GLib versions, it's not needed
|
|
This commit reverts:
https://github.com/mate-desktop/mate-notification-daemon/commit/52b7c3807e71278f2d902a79cf6c08c839a1b0ad
And it applies an alternative to fix the deprecated functions:
gdk_screen_get_width
gdk_screen_get_height
|
|
avoid deprecated:
gdk_screen_get_monitor_geometry
gdk_screen_get_monitor_at_point
|
|
|
|
|
|
|
|
Fix #117
|
|
The freedesktop specification states that clients may opt to use named icons
instead of textual labels on action buttons. In this instance, the icon name
is passed as the 'key' (actions[i+1]) element in the actions data passed
to the daemon.
For themes to render the icon, they should check the hints passed by the
client for a boolean value of "action-icons", and if it is set they should
then create an image button based on the key, and not the label.
Many applications now make use of action-icons, such as media players, to
provide self describing actions with well known icon names, such as playback
controls. In the absence of support for action-icons they fallback to less
useful buttons and generally less actions.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
|
|
By using a bit, rather than a byte for gbooleans.
https://bugzilla.gnome.org/show_bug.cgi?id=622556
taken from:
https://git.gnome.org/browse/notification-daemon/commit/?id=c43d398
|
|
|
|
|
|
This reverts commit 7d162d83a2008c25b3134fcdda8265f23d461585.
fixes https://github.com/mate-desktop/mate-notification-daemon/issues/91
|
|
GTK3 daemon: fix deprecated gdk_display_get_pointer
|
|
inspired from:
https://git.gnome.org/browse/notification-daemon/patch/?id=9f376d3
|
|
GValueArray is deprecated so move to GArray instead in
_notify_daemon_pixbuf_from_data_hint()
|
|
|
|
Don't forget to free the result of g_settings_get_string(). Also, change
`slocation' to proper type gchar* for storing results of
g_settings_get_string(). Furthermore, this allows to use that pointer in free()
without any casting.
|
|
|
|
static variables are already initialized to 0/NULL by default
|
|
static variables are already initialised to 0/NULL by default
|
|
G_LOG_LEVEL_ERROR is already always fatal so no need to pass it to
g_log_set_always_fatal()
|
|
fixes https://github.com/mate-desktop/mate-notification-daemon/issues/48
|
|
|
|
Avoid problematic comparison between two floats, remove two unneeded variables
and in general reduce the amount of work in that function
|
|
|
|
This was added in Glib 2.40 and we still target 2.36.
|
|
Since GTK+ 3.10.0 there is only one screen per display.
taken from https://git.gnome.org/browse/notification-daemon/commit/?id=66fd9bd
|
|
|
|
Exit with 0 (EXIT_SUCCESS) on idle due to the fact that some D-Bus
implementations like kdbus are tracking daemons' exit codes and will mark
mate-notification-daemon as if it failed if it exits with 1.
|
|
Add a nonnull assertion, remove unnecessary {} around one return
statement
|
|
Almost everything about bit fields are implementation defined and there
is a special type for storing booleans (which these bit fields were used
for) so use that instead because of portability
|
|
Closes https://github.com/mate-desktop/mate-notification-daemon/pull/52
|
|
fixes the issue with GLib >= 2.43,
https://git.gnome.org/browse/glib/commit/?id=8ff5668a458344da22d30491e3ce726d861b3619
Closes https://github.com/mate-desktop/mate-notification-daemon/pull/45
|
|
|
|
|
|
When switching monitors AND displaying notifications at the
same time, a rare situation might occur when notification
window will be added to two or more stacks. One of the
stacks will be removed soon enough, but the "destroy"
handler will persist and will be triggered when the window
disappears. This results in a reference to a freed memory
and (usually) a daemon crash, a typical one is
https://retrace.fedoraproject.org/faf/reports/359836/ for
example.
So, the removal handlers referring to a deleted stack must
be cancelled prior to removal.
Closes https://github.com/mate-desktop/mate-notification-daemon/pull/34
|