Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
g_variant_lookup works like g_variant_get, so using a format string of "v" only
works if the type is actually a GVariant. Since none of the hints have GVariant
values, that means every g_variant_get with a "v" format will fail.
Fix all of the g_variant_lookup calls so that they either unpack a value
directly, or use a "@" prefix when it's more convenient to fetch the value as
a GVariant pointer.
In addition, in cases where we do fetch a GVariant, make sure that we
unreference it afterward.
|
|
|
|
|
|
and drop additional checks for min/max GLib versions, it's not needed
|
|
Now that all of the elements are in place to support (dynamically) the
action icons, we can use the 'key' in place of the 'label' when the client
sends an hint requesting it.
Some other minor issues were corrected in this change, such as ensuring that
we always show *all* widgets inside of the notification window so that when
a live notification window is updated, the action box state is not then
hidden from view.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
Prior to this commit we would always end up adding multiple pie_countdown
widgets in a number of situations when updating the notification. In modern
media player apps, many updates are sent for the lifetime of a single
notification window, leading to new drawing areas being added and counting
down with each track/information change.
Note this hasn't been noticable for quite some time, because in many of the
themes the pie countdown hasn't actually been visible due to the actions
box having become hidden completely, meaning that the actions and pie show
very briefly, and are immediately nuked on a change to the notification.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
Each of the themes will have to detect the 'action-icons' hint passed to
them in 'set_notification_hints' to make a determination on whether or not
to use image based buttons, instead of textual buttons, in their actions
boxes.
This factory behaviour simply extends the existing checks for urgency-hint,
as well as unifying the code style between the various in-tree theme
implementations.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
|
|
|
|
|
|
taken from:
https://git.gnome.org/browse/notification-daemon/commit/?id=b156f34
|
|
|
|
|
|
fixes animation effects with compiz
|
|
|
|
|
|
Coco:fix the height of the entire notification window in gtk3 builds, not just the visible area This gives consistant position no matter what the height of the notification window, and never overlaps the panel regardless of panel position. Top, bottom, left, right panels tested along with top left, top right, bottom left, and bottom right notification locations. None overlapped, consistant spacing from notification window to panel in all cases-just like slider. The previous "fix" has been reverted and is not present in this commit.
|
|
|
|
|
|
|
|
|
|
|
|
No functional change but this makes the code a bit cleaner
and easier to read.
|
|
|
|
|
|
Fixes background in Gtk3
|
|
We really are checking if we have a compositer running
so composited fits better.
|
|
|
|
|
|
Rids us of more GTK_CHECK_VERSION
|
|
Rids us of some GTK_CHECK_VERSION
|
|
|
|
|
|
|
|
fixes https://github.com/mate-desktop/mate-notification-daemon/issues/55
|
|
Closes https://github.com/mate-desktop/mate-notification-daemon/pull/52
|
|
Closes https://github.com/mate-desktop/mate-notification-daemon/pull/38
|
|
Closes https://github.com/mate-desktop/mate-notification-daemon/issues/37
|
|
|
|
* Use GtkAllocation for both Gtk+ versions, added in 2.18
* Bump gdk-pixbuf required to 2.22 (release 2010)
* GDK_DISPLAY_XDISPLAY | Since always
* gdk_display_get_default | Since 2.22
* gdk_window_get_screen | Since 2.24
* gtk_widget_get_window | Since 2.14
|
|
Also fix a bug in add_notification_action in coco-theme
|
|
|
|
|
|
nodoka and coco theme
|
|
|