Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
g_variant_lookup works like g_variant_get, so using a format string of "v" only
works if the type is actually a GVariant. Since none of the hints have GVariant
values, that means every g_variant_get with a "v" format will fail.
Fix all of the g_variant_lookup calls so that they either unpack a value
directly, or use a "@" prefix when it's more convenient to fetch the value as
a GVariant pointer.
In addition, in cases where we do fetch a GVariant, make sure that we
unreference it afterward.
|
|
|
|
and drop additional checks for min/max GLib versions, it's not needed
|
|
Prior to this change we could end up with a warped pie countdown if the
buttons were of a larger size, breaking the constraints of the pie to be
vertically stretched.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
Now that all of the elements are in place to support (dynamically) the
action icons, we can use the 'key' in place of the 'label' when the client
sends an hint requesting it.
Some other minor issues were corrected in this change, such as ensuring that
we always show *all* widgets inside of the notification window so that when
a live notification window is updated, the action box state is not then
hidden from view.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
Prior to this commit we would always end up adding multiple pie_countdown
widgets in a number of situations when updating the notification. In modern
media player apps, many updates are sent for the lifetime of a single
notification window, leading to new drawing areas being added and counting
down with each track/information change.
Note this hasn't been noticable for quite some time, because in many of the
themes the pie countdown hasn't actually been visible due to the actions
box having become hidden completely, meaning that the actions and pie show
very briefly, and are immediately nuked on a change to the notification.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
Each of the themes will have to detect the 'action-icons' hint passed to
them in 'set_notification_hints' to make a determination on whether or not
to use image based buttons, instead of textual buttons, in their actions
boxes.
This factory behaviour simply extends the existing checks for urgency-hint,
as well as unifying the code style between the various in-tree theme
implementations.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
|
|
|
|
|
|
theme looks really better now
|
|
taken from:
https://git.gnome.org/browse/notification-daemon/commit/?id=b156f34
|
|
|
|
we dropped color reversing in d80ac825a8815317e06d206c2199bedfe0474f85 anyway
as it never worked properly in GTK+3, so now override_style function does nothing
|
|
|
|
|
|
|
|
|
|
|
|
|
|
It's enough to call gtk_widget_override_* functions on the toplevel element, child elements will inherit the style properly. Fixes issue #90.
|
|
inspired from:
https://git.gnome.org/browse/metacity/commit/?id=f201335
|
|
|
|
taken from:
https://git.gnome.org/browse/notification-daemon/commit/?id=9d38817
|
|
|
|
- theme.c:1010:31: warning: passing argument 1 of 'gtk_style_context_get_color' from incompatible pointer type [-Wincompatible-pointer-types]
gtk_style_context_get_color (context, GTK_STATE_FLAG_NORMAL, &color);
- theme.c:1011:25: warning: passing argument 1 of 'gtk_style_context_get' from incompatible pointer type [-Wincompatible-pointer-types]
gtk_style_context_get (context, GTK_STATE_FLAG_NORMAL, "background-color", &fg_color, NULL);
- theme.c:979:19: warning: variable 'style' set but not used [-Wunused-but-set-variable]
GtkStyleContext* style;
|
|
gtk_style_context_get_background_color"
This commit breaks the bg of notifications, in result notifications are unreadable, black fg color on black bg.
This reverts commit 0fb782d2dcc129ab0858ea0d4399f6c183cb20c1.
|
|
|
|
|
|
|
|
This is now the same as coco and nodoka.
|
|
Also we already shape windows in paint_window and it is probably
wise to redraw anyway on compositing change.
|
|
|
|
|
|
taken from
https://git.gnome.org/browse/notification-daemon/commit/?id=2f0409b
|
|
|
|
|
|
|
|
fixes https://github.com/mate-desktop/mate-notification-daemon/issues/55
|
|
Closes https://github.com/mate-desktop/mate-notification-daemon/pull/52
|
|
* Use GtkAllocation for both Gtk+ versions, added in 2.18
* Bump gdk-pixbuf required to 2.22 (release 2010)
* GDK_DISPLAY_XDISPLAY | Since always
* gdk_display_get_default | Since 2.22
* gdk_window_get_screen | Since 2.24
* gtk_widget_get_window | Since 2.14
|
|
Also fix a bug in add_notification_action in coco-theme
|
|
|
|
|
|
|
|
|