Age | Commit message (Collapse) | Author | Files | Lines |
|
g_variant_lookup works like g_variant_get, so using a format string of "v" only
works if the type is actually a GVariant. Since none of the hints have GVariant
values, that means every g_variant_get with a "v" format will fail.
Fix all of the g_variant_lookup calls so that they either unpack a value
directly, or use a "@" prefix when it's more convenient to fetch the value as
a GVariant pointer.
In addition, in cases where we do fetch a GVariant, make sure that we
unreference it afterward.
|
|
|
|
|
|
|
|
|
|
|
|
- src/daemon/daemon.c
- src/daemon/daemon.h
|
|
|
|
|
|
|
|
|
|
|
|
|
|
libglib2.0-bin.
|
|
and drop additional checks for min/max GLib versions, it's not needed
|
|
This commit reverts:
https://github.com/mate-desktop/mate-notification-daemon/commit/52b7c3807e71278f2d902a79cf6c08c839a1b0ad
And it applies an alternative to fix the deprecated functions:
gdk_screen_get_width
gdk_screen_get_height
|
|
avoid deprecated:
gdk_screen_get_monitor_geometry
gdk_screen_get_monitor_at_point
|
|
|
|
|
|
|
|
Fix #117
|
|
Prior to this change we could end up with a warped pie countdown if the
buttons were of a larger size, breaking the constraints of the pie to be
vertically stretched.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
Now that all of the elements are in place to support (dynamically) the
action icons, we can use the 'key' in place of the 'label' when the client
sends an hint requesting it.
Some other minor issues were corrected in this change, such as ensuring that
we always show *all* widgets inside of the notification window so that when
a live notification window is updated, the action box state is not then
hidden from view.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
Prior to this commit we would always end up adding multiple pie_countdown
widgets in a number of situations when updating the notification. In modern
media player apps, many updates are sent for the lifetime of a single
notification window, leading to new drawing areas being added and counting
down with each track/information change.
Note this hasn't been noticable for quite some time, because in many of the
themes the pie countdown hasn't actually been visible due to the actions
box having become hidden completely, meaning that the actions and pie show
very briefly, and are immediately nuked on a change to the notification.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
Each of the themes will have to detect the 'action-icons' hint passed to
them in 'set_notification_hints' to make a determination on whether or not
to use image based buttons, instead of textual buttons, in their actions
boxes.
This factory behaviour simply extends the existing checks for urgency-hint,
as well as unifying the code style between the various in-tree theme
implementations.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
The freedesktop specification states that clients may opt to use named icons
instead of textual labels on action buttons. In this instance, the icon name
is passed as the 'key' (actions[i+1]) element in the actions data passed
to the daemon.
For themes to render the icon, they should check the hints passed by the
client for a boolean value of "action-icons", and if it is set they should
then create an image button based on the key, and not the label.
Many applications now make use of action-icons, such as media players, to
provide self describing actions with well known icon names, such as playback
controls. In the absence of support for action-icons they fallback to less
useful buttons and generally less actions.
Signed-off-by: Ikey Doherty <[email protected]>
|
|
|
|
|
|
|
|
|
|
theme looks really better now
|
|
|
|
taken from:
https://git.gnome.org/browse/notification-daemon/commit/?id=b156f34
|
|
|
|
By using a bit, rather than a byte for gbooleans.
https://bugzilla.gnome.org/show_bug.cgi?id=622556
taken from:
https://git.gnome.org/browse/notification-daemon/commit/?id=c43d398
|
|
|
|
|
|
|
|
|
|
|
|
we dropped color reversing in d80ac825a8815317e06d206c2199bedfe0474f85 anyway
as it never worked properly in GTK+3, so now override_style function does nothing
|
|
|
|
|
|
fixes animation effects with compiz
|
|
|
|
|
|
|
|
|
|
It's enough to call gtk_widget_override_* functions on the toplevel element, child elements will inherit the style properly. Fixes issue #90.
|
|
inspired from:
https://git.gnome.org/browse/metacity/commit/?id=f201335
|