Ensure proper translation of the about dialog title

Note that GTK+ sets a default title of _("About %s") on the dialog
window (where %s is replaced by the name of the application, but
in order to ensure proper translation of the title, applications
should set the title property explicitly when constructing a
GtkAboutDialog

https://developer.gnome.org/gtk3/stable/GtkAboutDialog.html

8 files changed, 78 insertions, 43 deletions

diff --git a/applets/clock/clock.c b/applets/clock/clock.c
index 8b60341e..b752099a 100644
--- a/applets/clock/clock.c
+++ b/applets/clock/clock.c
@@ -3293,6 +3293,7 @@ static void display_about_dialog(GtkAction* action, ClockData* cd)
 
         gtk_show_about_dialog(NULL,
                 "program-name", _("Clock"),
+                "title", _("About Clock"),
                 "authors", authors,
                 "comments", _("The Clock displays the current time and date"),
                 "copyright", _("Copyright \xc2\xa9 1998-2004 Free Software Foundation, Inc.\n"
diff --git a/applets/fish/fish.c b/applets/fish/fish.c
index 922d6ba0..976c3087 100644
--- a/applets/fish/fish.c
+++ b/applets/fish/fish.c
@@ -556,6 +556,7 @@ static void display_about_dialog(GtkAction* action, FishApplet* fish)
 
 	gtk_show_about_dialog(NULL,
 		"program-name", _("Fish"),
+		"title", _("About Fish"),
 		"authors", authors,
 		"comments", descr,
 		"copyright", _("Copyright \xc2\xa9 1998-2002 Free Software Foundation, Inc.\n"
diff --git a/applets/notification_area/main.c b/applets/notification_area/main.c
index 613a2470..12a1e073 100644
--- a/applets/notification_area/main.c
+++ b/applets/notification_area/main.c
@@ -274,6 +274,7 @@ static void about_cb(GtkAction* action, NaTrayApplet* applet)
 
 	gtk_show_about_dialog(NULL,
 		"program-name", _("Notification Area"),
+		"title", _("About Notification Area"),
 		"authors", authors,
 		//"comments", _(comments),
 		"copyright", _("Copyright \xc2\xa9 2002 Red Hat, Inc.\n"
diff --git a/applets/wncklet/showdesktop.c b/applets/wncklet/showdesktop.c
index 78dd2778..d827f490 100644
--- a/applets/wncklet/showdesktop.c
+++ b/applets/wncklet/showdesktop.c
@@ -496,6 +496,7 @@ static void display_about_dialog(GtkAction* action, ShowDesktopData* sdd)
 
 	gtk_show_about_dialog(GTK_WINDOW(sdd->applet),
 		"program-name", _("Show Desktop Button"),
+		"title", _("About Show Desktop Button"),
 		"authors", authors,
 		"comments", _("This button lets you hide all windows and show the desktop."),
 		"copyright", _("Copyright \xc2\xa9 2002 Red Hat, Inc.\n"
diff --git a/applets/wncklet/window-list.c b/applets/wncklet/window-list.c
index 2a5ea4ba..3cdcd834 100644
--- a/applets/wncklet/window-list.c
+++ b/applets/wncklet/window-list.c
@@ -559,6 +559,7 @@ static void display_about_dialog(GtkAction* action, TasklistData* tasklist)
 
 	gtk_show_about_dialog(GTK_WINDOW(tasklist->applet),
 		"program-name", _("Window List"),
+		"title", _("About Window List"),
 		"authors", authors,
 		"comments", _("The Window List shows a list of all windows in a set of buttons and lets you browse them."),
 		"copyright", _("Copyright \xc2\xa9 2002 Red Hat, Inc.\n"
diff --git a/applets/wncklet/window-menu.c b/applets/wncklet/window-menu.c
index fc10cb2a..83790d47 100644
--- a/applets/wncklet/window-menu.c
+++ b/applets/wncklet/window-menu.c
@@ -74,6 +74,7 @@ static void window_menu_about(GtkAction* action, WindowMenu* window_menu)
 
 	gtk_show_about_dialog(GTK_WINDOW(window_menu->applet),
 		"program-name", _("Window Selector"),
+		"title", _("About Window Selector"),
 		"authors", authors,
 		"comments", _("The Window Selector shows a list of all windows in a menu and lets you browse them."),
 		"copyright", _("Copyright \xc2\xa9 2000 Helix Code, Inc.\n"
diff --git a/applets/wncklet/workspace-switcher.c b/applets/wncklet/workspace-switcher.c
index d3475e0d..4089c85f 100644
--- a/applets/wncklet/workspace-switcher.c
+++ b/applets/wncklet/workspace-switcher.c
@@ -632,6 +632,7 @@ static void display_about_dialog(GtkAction* action, PagerData* pager)
 
 	gtk_show_about_dialog(GTK_WINDOW(pager->applet),
 		"program-name", _("Workspace Switcher"),
+		"title", _("About Workspace Switcher"),
 		"authors", authors,
 		"comments", _("The Workspace Switcher shows you a small version of your workspaces that lets you manage your windows."),
 		"copyright", _("Copyright \xc2\xa9 2002 Red Hat, Inc.\n"
diff --git a/mate-panel.pot b/mate-panel.pot
index 3b5dd086..46b1d786 100644
--- a/mate-panel.pot
+++ b/mate-panel.pot
@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: MATE Desktop Environment\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2019-02-15 19:25+0100\n"
+"POT-Creation-Date: 2019-02-17 10:28+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[email protected]>\n"
@@ -160,17 +160,17 @@ msgstr ""
 msgid "Failed to set the system time"
 msgstr ""
 
-#: ../applets/clock/clock.c:1863 ../applets/fish/fish.c:1693
-#: ../applets/notification_area/main.c:291 ../applets/wncklet/window-list.c:171
+#: ../applets/clock/clock.c:1863 ../applets/fish/fish.c:1694
+#: ../applets/notification_area/main.c:292 ../applets/wncklet/window-list.c:171
 #: ../applets/wncklet/workspace-switcher.c:389
 msgid "_Preferences"
 msgstr ""
 
 #: ../applets/clock/clock.c:1866 ../applets/clock/clock.ui.h:7
-#: ../applets/fish/fish.c:1696 ../applets/fish/fish.ui.h:2
-#: ../applets/notification_area/main.c:294 ../applets/wncklet/showdesktop.c:241
+#: ../applets/fish/fish.c:1697 ../applets/fish/fish.ui.h:2
+#: ../applets/notification_area/main.c:295 ../applets/wncklet/showdesktop.c:241
 #: ../applets/wncklet/window-list.c:179 ../applets/wncklet/window-list.ui.h:2
-#: ../applets/wncklet/window-menu.c:97
+#: ../applets/wncklet/window-menu.c:98
 #: ../applets/wncklet/workspace-switcher.c:397
 #: ../applets/wncklet/workspace-switcher.ui.h:2 ../mate-panel/drawer.c:563
 #: ../mate-panel/panel-action-button.c:737 ../mate-panel/panel-addto.c:1241
@@ -182,9 +182,9 @@ msgstr ""
 msgid "_Help"
 msgstr ""
 
-#: ../applets/clock/clock.c:1869 ../applets/fish/fish.c:1699
-#: ../applets/notification_area/main.c:297 ../applets/wncklet/showdesktop.c:249
-#: ../applets/wncklet/window-list.c:187 ../applets/wncklet/window-menu.c:105
+#: ../applets/clock/clock.c:1869 ../applets/fish/fish.c:1700
+#: ../applets/notification_area/main.c:298 ../applets/wncklet/showdesktop.c:249
+#: ../applets/wncklet/window-list.c:187 ../applets/wncklet/window-menu.c:106
 #: ../applets/wncklet/workspace-switcher.c:405
 msgid "_About"
 msgstr ""
@@ -222,20 +222,24 @@ msgstr ""
 msgid "Clock"
 msgstr ""
 
-#: ../applets/clock/clock.c:3297
-msgid "The Clock displays the current time and date"
+#: ../applets/clock/clock.c:3296
+msgid "About Clock"
 msgstr ""
 
 #: ../applets/clock/clock.c:3298
+msgid "The Clock displays the current time and date"
+msgstr ""
+
+#: ../applets/clock/clock.c:3299
 msgid ""
 "Copyright © 1998-2004 Free Software Foundation, Inc.\n"
 "Copyright © 2012-2019 MATE developers"
 msgstr ""
 
-#: ../applets/clock/clock.c:3302 ../applets/fish/fish.c:566
-#: ../applets/notification_area/main.c:285 ../applets/wncklet/showdesktop.c:507
-#: ../applets/wncklet/window-list.c:570 ../applets/wncklet/window-menu.c:87
-#: ../applets/wncklet/workspace-switcher.c:643
+#: ../applets/clock/clock.c:3303 ../applets/fish/fish.c:567
+#: ../applets/notification_area/main.c:286 ../applets/wncklet/showdesktop.c:508
+#: ../applets/wncklet/window-list.c:571 ../applets/wncklet/window-menu.c:88
+#: ../applets/wncklet/workspace-switcher.c:644
 #: ../mate-panel/panel-context-menu.c:124
 msgid "translator-credits"
 msgstr ""
@@ -272,7 +276,7 @@ msgstr ""
 msgid "Time _Settings"
 msgstr ""
 
-#: ../applets/clock/clock.ui.h:9 ../applets/fish/fish.c:852
+#: ../applets/clock/clock.ui.h:9 ../applets/fish/fish.c:853
 #: ../applets/fish/fish.ui.h:3
 #: ../applets/notification_area/notification-area-preferences-dialog.ui.h:2
 #: ../applets/wncklet/window-list.ui.h:3
@@ -619,8 +623,8 @@ msgstr ""
 msgid "Images"
 msgstr ""
 
-#: ../applets/fish/fish.c:534 ../applets/fish/fish.c:577
-#: ../applets/fish/fish.c:683
+#: ../applets/fish/fish.c:534 ../applets/fish/fish.c:578
+#: ../applets/fish/fish.c:684
 #, no-c-format
 msgid "%s the Fish"
 msgstr ""
@@ -642,28 +646,32 @@ msgstr ""
 msgid "Fish"
 msgstr ""
 
-#: ../applets/fish/fish.c:561
+#: ../applets/fish/fish.c:559
+msgid "About Fish"
+msgstr ""
+
+#: ../applets/fish/fish.c:562
 msgid ""
 "Copyright © 1998-2002 Free Software Foundation, Inc.\n"
 "Copyright © 2002-2005 Vincent Untz\n"
 "Copyright © 2012-2019 MATE developers"
 msgstr ""
 
-#: ../applets/fish/fish.c:578
+#: ../applets/fish/fish.c:579
 #, c-format
 msgid "%s the Fish, a contemporary oracle"
 msgstr ""
 
-#: ../applets/fish/fish.c:644
+#: ../applets/fish/fish.c:645
 msgid "Unable to locate the command to execute"
 msgstr ""
 
-#: ../applets/fish/fish.c:688
+#: ../applets/fish/fish.c:689
 #, no-c-format
 msgid "%s the Fish Says:"
 msgstr ""
 
-#: ../applets/fish/fish.c:751
+#: ../applets/fish/fish.c:752
 #, c-format
 msgid ""
 "Unable to read output from command\n"
@@ -671,16 +679,16 @@ msgid ""
 "Details: %s"
 msgstr ""
 
-#: ../applets/fish/fish.c:848
+#: ../applets/fish/fish.c:849
 msgid "_Speak again"
 msgstr ""
 
-#: ../applets/fish/fish.c:929
+#: ../applets/fish/fish.c:930
 #, c-format
 msgid "The configured command is not working and has been replaced by: %s"
 msgstr ""
 
-#: ../applets/fish/fish.c:962
+#: ../applets/fish/fish.c:963
 #, c-format
 msgid ""
 "Unable to execute '%s'\n"
@@ -688,7 +696,7 @@ msgid ""
 "Details: %s"
 msgstr ""
 
-#: ../applets/fish/fish.c:978
+#: ../applets/fish/fish.c:979
 #, c-format
 msgid ""
 "Unable to read from '%s'\n"
@@ -696,15 +704,15 @@ msgid ""
 "Details: %s"
 msgstr ""
 
-#: ../applets/fish/fish.c:1550
+#: ../applets/fish/fish.c:1551
 msgid "The water needs changing"
 msgstr ""
 
-#: ../applets/fish/fish.c:1552
+#: ../applets/fish/fish.c:1553
 msgid "Look at today's date!"
 msgstr ""
 
-#: ../applets/fish/fish.c:1634
+#: ../applets/fish/fish.c:1635
 #, c-format
 msgid "%s the Fish, the fortune teller"
 msgstr ""
@@ -831,8 +839,12 @@ msgstr ""
 msgid "Notification Area"
 msgstr ""
 
+#: ../applets/notification_area/main.c:277
+msgid "About Notification Area"
+msgstr ""
+
 #. "comments", _(comments),
-#: ../applets/notification_area/main.c:279
+#: ../applets/notification_area/main.c:280
 msgid ""
 "Copyright © 2002 Red Hat, Inc.\n"
 "Copyright © 2003-2006 Vincent Untz\n"
@@ -840,7 +852,7 @@ msgid ""
 "Copyright © 2012-2019 MATE developers"
 msgstr ""
 
-#: ../applets/notification_area/main.c:487
+#: ../applets/notification_area/main.c:488
 msgid "Panel Notification Area"
 msgstr ""
 
@@ -962,7 +974,7 @@ msgid "Factory for the window navigation related applets"
 msgstr ""
 
 #: ../applets/wncklet/org.mate.panel.Wncklet.mate-panel-applet.in.in.h:3
-#: ../applets/wncklet/window-menu.c:76 ../applets/wncklet/window-menu.c:226
+#: ../applets/wncklet/window-menu.c:76 ../applets/wncklet/window-menu.c:227
 msgid "Window Selector"
 msgstr ""
 
@@ -1017,19 +1029,23 @@ msgstr ""
 msgid "Show Desktop Button"
 msgstr ""
 
-#: ../applets/wncklet/showdesktop.c:500
+#: ../applets/wncklet/showdesktop.c:499
+msgid "About Show Desktop Button"
+msgstr ""
+
+#: ../applets/wncklet/showdesktop.c:501
 msgid "This button lets you hide all windows and show the desktop."
 msgstr ""
 
-#: ../applets/wncklet/showdesktop.c:501 ../applets/wncklet/window-list.c:564
-#: ../applets/wncklet/workspace-switcher.c:637
+#: ../applets/wncklet/showdesktop.c:502 ../applets/wncklet/window-list.c:565
+#: ../applets/wncklet/workspace-switcher.c:638
 msgid ""
 "Copyright © 2002 Red Hat, Inc.\n"
 "Copyright © 2011 Perberos\n"
 "Copyright © 2012-2019 MATE developers"
 msgstr ""
 
-#: ../applets/wncklet/showdesktop.c:528
+#: ../applets/wncklet/showdesktop.c:529
 msgid ""
 "Your window manager does not support the show desktop button, or you are not "
 "running a window manager."
@@ -1039,7 +1055,11 @@ msgstr ""
 msgid "_System Monitor"
 msgstr ""
 
-#: ../applets/wncklet/window-list.c:563
+#: ../applets/wncklet/window-list.c:562
+msgid "About Window List"
+msgstr ""
+
+#: ../applets/wncklet/window-list.c:564
 msgid ""
 "The Window List shows a list of all windows in a set of buttons and lets you "
 "browse them."
@@ -1089,13 +1109,17 @@ msgstr ""
 msgid "Restore to na_tive workspace"
 msgstr ""
 
-#: ../applets/wncklet/window-menu.c:78
+#: ../applets/wncklet/window-menu.c:77
+msgid "About Window Selector"
+msgstr ""
+
+#: ../applets/wncklet/window-menu.c:79
 msgid ""
 "The Window Selector shows a list of all windows in a menu and lets you "
 "browse them."
 msgstr ""
 
-#: ../applets/wncklet/window-menu.c:79
+#: ../applets/wncklet/window-menu.c:80
 msgid ""
 "Copyright © 2000 Helix Code, Inc.\n"
 "Copyright © 2001 Free Software Foundation, Inc.\n"
@@ -1105,17 +1129,21 @@ msgid ""
 msgstr ""
 
 #: ../applets/wncklet/workspace-switcher.c:240
-#: ../applets/wncklet/workspace-switcher.c:938
+#: ../applets/wncklet/workspace-switcher.c:939
 #: ../applets/wncklet/workspace-switcher.ui.h:6
 msgid "rows"
 msgstr ""
 
 #: ../applets/wncklet/workspace-switcher.c:240
-#: ../applets/wncklet/workspace-switcher.c:938
+#: ../applets/wncklet/workspace-switcher.c:939
 msgid "columns"
 msgstr ""
 
-#: ../applets/wncklet/workspace-switcher.c:636
+#: ../applets/wncklet/workspace-switcher.c:635
+msgid "About Workspace Switcher"
+msgstr ""
+
+#: ../applets/wncklet/workspace-switcher.c:637
 msgid ""
 "The Workspace Switcher shows you a small version of your workspaces that "
 "lets you manage your windows."