wncklet: stop segfaults, warnings on removing in-process switcher, window-list

Fixes window list, workspace switcher. Window menu and show desktop no warnings or segfaults on removal when built in process

1 files changed, 29 insertions, 10 deletions

diff --git a/applets/wncklet/window-list.c b/applets/wncklet/window-list.c
index 35bdbd45..e3d2e208 100644
--- a/applets/wncklet/window-list.c
+++ b/applets/wncklet/window-list.c
@@ -63,6 +63,7 @@ static void call_system_monitor(GtkAction* action, TasklistData* tasklist);
 static void display_properties_dialog(GtkAction* action, TasklistData* tasklist);
 static void display_help_dialog(GtkAction* action, TasklistData* tasklist);
 static void display_about_dialog(GtkAction* action, TasklistData* tasklist);
+static void destroy_tasklist(GtkWidget* widget, TasklistData* tasklist);
 
 static void tasklist_update(TasklistData* tasklist)
 {
@@ -147,16 +148,6 @@ static void applet_change_pixel_size(MatePanelApplet* applet, gint size, Tasklis
 	tasklist_update(tasklist);
 }
 
-static void destroy_tasklist(GtkWidget* widget, TasklistData* tasklist)
-{
-	g_object_unref(tasklist->settings);
-
-	if (tasklist->properties_dialog)
-		gtk_widget_destroy(tasklist->properties_dialog);
-
-	g_free(tasklist);
-}
-
 /* TODO: this is sad, should be used a function to retrieve  applications from
  *  .desktop or some like that. */
 static const char* system_monitors[] = {
@@ -694,3 +685,31 @@ static void display_properties_dialog(GtkAction* action, TasklistData* tasklist)
 	gtk_window_set_screen(GTK_WINDOW(tasklist->properties_dialog), gtk_widget_get_screen(tasklist->applet));
 	gtk_window_present(GTK_WINDOW(tasklist->properties_dialog));
 }
+
+static void destroy_tasklist(GtkWidget* widget, TasklistData* tasklist)
+{
+
+	g_signal_handlers_disconnect_by_func(G_OBJECT(tasklist->applet),
+						G_CALLBACK(applet_change_orient), tasklist);
+	g_signal_handlers_disconnect_by_func(G_OBJECT(tasklist->applet),
+						G_CALLBACK(applet_change_pixel_size), tasklist);
+	g_signal_handlers_disconnect_by_func(G_OBJECT(tasklist->applet),
+						G_CALLBACK(applet_change_background), tasklist);
+	g_signal_handlers_disconnect_by_func (tasklist->settings,
+					  G_CALLBACK (display_all_workspaces_changed),
+					  tasklist);
+	g_signal_handlers_disconnect_by_func (tasklist->settings,
+					  G_CALLBACK (group_windows_changed),
+					  tasklist);
+	g_signal_handlers_disconnect_by_func (tasklist->settings,
+					  G_CALLBACK (move_unminimized_windows_changed),
+					  tasklist);
+
+	g_object_unref(tasklist->settings);
+
+	if (tasklist->properties_dialog)
+		gtk_widget_destroy(tasklist->properties_dialog);
+
+	g_free(tasklist);
+
+}