diff options
| author | Pablo Barciela <[email protected]> | 2020-04-15 05:33:24 +0200 |
|---|---|---|
| committer | Robert Antoni Buj Gelonch <[email protected]> | 2020-04-15 17:25:45 +0200 |
| commit | 1f3566651994ead4813dc3253f65ec8a523ecf35 (patch) | |
| tree | 2e406970577bef1e621d027718424149929a79ed /backend | |
| parent | 8170ddddafadbd2268de83872536eb8c385cfa6a (diff) | |
| download | atril-1f3566651994ead4813dc3253f65ec8a523ecf35.tar.bz2 atril-1f3566651994ead4813dc3253f65ec8a523ecf35.tar.xz | |
Fix cppcheck [knownConditionTrueFalse] warnings
Fixes the warnings:
backend/comics/comics-document.c:767:21: style: Condition 'bytes<=0' is always true [knownConditionTrueFalse]
backend/epub/minizip/unzip.c:603:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse]
properties/ev-properties-view.c:197:33: style: Condition 'text' is always true [knownConditionTrueFalse]
shell/ev-sidebar-thumbnails.c:598:7: style: Condition '!loading_icon' is always true [knownConditionTrueFalse]
shell/main.c:115:6: style: Condition '!error' is always true [knownConditionTrueFalse]
Diffstat (limited to 'backend')
| -rw-r--r-- | backend/comics/comics-document.c | 2 | ||||
| -rw-r--r-- | backend/epub/minizip/unzip.c | 6 |
2 files changed, 1 insertions, 7 deletions
diff --git a/backend/comics/comics-document.c b/backend/comics/comics-document.c index ae37d23a..d799b208 100644 --- a/backend/comics/comics-document.c +++ b/backend/comics/comics-document.c @@ -764,7 +764,7 @@ comics_document_render_pixbuf (EvDocument *document, if (bytes > 0) { gdk_pixbuf_loader_write (loader, buf, bytes, NULL); - } else if (bytes <= 0) { + } else { close (outpipe); gdk_pixbuf_loader_close (loader, NULL); outpipe = -1; diff --git a/backend/epub/minizip/unzip.c b/backend/epub/minizip/unzip.c index 90935043..2ed54a11 100644 --- a/backend/epub/minizip/unzip.c +++ b/backend/epub/minizip/unzip.c @@ -119,9 +119,6 @@ #define SIZEZIPLOCALHEADER (0x1e) -const char unz_copyright[] = - " unzip 1.01 Copyright 1998-2004 Gilles Vollant - http://www.winimage.com/zLibDll"; - /* unz_file_info_interntal contain internal info about a file in zipfile*/ typedef struct unz_file_info64_internal_s { @@ -600,9 +597,6 @@ local unzFile unzOpenInternal (const void *path, int err=UNZ_OK; - if (unz_copyright[0]!=' ') - return NULL; - us.z_filefunc.zseek32_file = NULL; us.z_filefunc.ztell32_file = NULL; if (pzlib_filefunc64_32_def==NULL) |