diff options
| author | Pablo Barciela <[email protected]> | 2020-04-15 05:33:24 +0200 |
|---|---|---|
| committer | Robert Antoni Buj Gelonch <[email protected]> | 2020-04-15 17:25:45 +0200 |
| commit | 1f3566651994ead4813dc3253f65ec8a523ecf35 (patch) | |
| tree | 2e406970577bef1e621d027718424149929a79ed /shell/ev-sidebar-thumbnails.c | |
| parent | 8170ddddafadbd2268de83872536eb8c385cfa6a (diff) | |
| download | atril-1f3566651994ead4813dc3253f65ec8a523ecf35.tar.bz2 atril-1f3566651994ead4813dc3253f65ec8a523ecf35.tar.xz | |
Fix cppcheck [knownConditionTrueFalse] warnings
Fixes the warnings:
backend/comics/comics-document.c:767:21: style: Condition 'bytes<=0' is always true [knownConditionTrueFalse]
backend/epub/minizip/unzip.c:603:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse]
properties/ev-properties-view.c:197:33: style: Condition 'text' is always true [knownConditionTrueFalse]
shell/ev-sidebar-thumbnails.c:598:7: style: Condition '!loading_icon' is always true [knownConditionTrueFalse]
shell/main.c:115:6: style: Condition '!error' is always true [knownConditionTrueFalse]
Diffstat (limited to 'shell/ev-sidebar-thumbnails.c')
| -rw-r--r-- | shell/ev-sidebar-thumbnails.c | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/shell/ev-sidebar-thumbnails.c b/shell/ev-sidebar-thumbnails.c index 72c365ec..05a9049f 100644 --- a/shell/ev-sidebar-thumbnails.c +++ b/shell/ev-sidebar-thumbnails.c @@ -581,8 +581,6 @@ ev_sidebar_thumbnails_fill_model (EvSidebarThumbnails *sidebar_thumbnails) EvSidebarThumbnailsPrivate *priv = sidebar_thumbnails->priv; GtkTreeIter iter; int i; - gint prev_width = -1; - gint prev_height = -1; for (i = 0; i < sidebar_thumbnails->priv->n_pages; i++) { gchar *page_label; @@ -593,16 +591,11 @@ ev_sidebar_thumbnails_fill_model (EvSidebarThumbnails *sidebar_thumbnails) page_label = ev_document_get_page_label (priv->document, i); page_string = g_markup_printf_escaped ("<i>%s</i>", page_label); ev_thumbnails_size_cache_get_size (sidebar_thumbnails->priv->size_cache, i, - sidebar_thumbnails->priv->rotation, - &width, &height); - if (!loading_icon || (width != prev_width && height != prev_height)) { - loading_icon = - ev_sidebar_thumbnails_get_loading_icon (sidebar_thumbnails, - width, height); - } + sidebar_thumbnails->priv->rotation, + &width, &height); - prev_width = width; - prev_height = height; + loading_icon = ev_sidebar_thumbnails_get_loading_icon (sidebar_thumbnails, + width, height); gtk_list_store_append (priv->list_store, &iter); gtk_list_store_set (priv->list_store, &iter, |