summaryrefslogtreecommitdiff
path: root/backend
AgeCommit message (Collapse)AuthorFilesLines
2020-04-23djvu-text-page: Fix cppcheck [clarifyCalculation] warningsPablo Barciela1-2/+2
Fixes the warnings: backend/djvu/djvu-text-page.c:46:31: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] g_strjoin (delimit & 2 ? "\n" : ^ backend/djvu/djvu-text-page.c:47:28: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation] delimit & 1 ? " " : NULL, ^
2020-04-15Fix cppcheck [knownConditionTrueFalse] warningsPablo Barciela2-7/+1
Fixes the warnings: backend/comics/comics-document.c:767:21: style: Condition 'bytes<=0' is always true [knownConditionTrueFalse] backend/epub/minizip/unzip.c:603:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse] properties/ev-properties-view.c:197:33: style: Condition 'text' is always true [knownConditionTrueFalse] shell/ev-sidebar-thumbnails.c:598:7: style: Condition '!loading_icon' is always true [knownConditionTrueFalse] shell/main.c:115:6: style: Condition '!error' is always true [knownConditionTrueFalse]
2020-04-14Remove strict-prototypes warningrbuj2-2/+2
2020-04-14ev-window/epub-document: remove unused functionsPablo Barciela1-11/+0
Fixes the build warnings: ev-window.c:6379:1: warning: function 'menubar_deactivate_cb' is not needed and will not be emitted [-Wunneeded-internal-declaration] menubar_deactivate_cb (GtkWidget *menubar, ^ epub-document.c:946:1: warning: function 'check_add_page_numbers' is not needed and will not be emitted [-Wunneeded-internal-declaration] check_add_page_numbers(linknode *listdata, contentListNode *comparenode) ^
2020-04-14ev-poppler: remove unused variablePablo Barciela1-1/+0
2020-04-13epub-document: Remove unused-variable warningrbuj1-7/+5
2020-04-10epub backend: build with WARN_CFLAGS instead WARN_CXXFLAGSPablo Barciela1-2/+2
2020-03-12dviread: ‘inline’ is not at beginning of declarationrbuj1-3/+3
2020-01-31Fix year 2038 issue with signed 32-bit integersrbuj1-2/+3
GTime is defined to always be a signed 32-bit integer, it will overflow in the year 2038.
2020-01-15pdf: Fix memory leak when adding new text annotationsCarlos Garcia Campos1-1/+1
origin commit: https://gitlab.gnome.org/GNOME/evince/commit/a182f12
2019-11-11migrate from intltool to gettextWu Xiaotian18-46/+49
2019-08-20tiff: Handle failure from TIFFReadRGBAImageOrientedVictor Kareh1-9/+17
The TIFFReadRGBAImageOriented function returns zero if it was unable to read the image. Return NULL in this case instead of displaying uninitialized memory. This addresses CVE-2019-11459 upstream commit: https://gitlab.gnome.org/GNOME/evince/commit/234f034a4
2019-07-27Fix buffer overflow in backend/tiff-document.clukefromdc1-6/+9
Apply https://gitlab.gnome.org/GNOME/evince/commit/e02fe9170ad0ac2fd46c75329c4f1d4502d4a362
2019-07-01Remove trailing whitespacesLaurent Napias52-1409/+1409
2019-01-21tiff: fix possible NULL pointer dereferencemonsta1-1/+2
2019-01-21pdf: add missing break statementmonsta1-0/+1
2018-12-20comics: fix incorrect mimetype saying to open and thumbnail all rarfilesEli Schwartz1-1/+1
application/vnd.rar is for files with the .rar extension, application/vnd.comicbook-rar is the subtype for files with the .cbr extension.
2018-11-07comics: support application/vnd.rar MIME typePablo Barciela1-1/+1
Fixes https://github.com/mate-desktop/atril/issues/341
2018-03-16epub: allow to save epub documentsraveit651-1/+5
inspired by: https://github.com/linuxmint/xreader/commit/63a28f https://github.com/linuxmint/xreader/issues/165
2018-03-16epub: fix loading epub thumbnailsMickael Albertus1-3/+4
origin commit: https://github.com/linuxmint/xreader/commit/6ed0ee1 Note: origin commit causes some serious build warnings, ......fixed.
2018-01-16epub: make minizip support more BSD variantsmonsta1-1/+1
closes https://github.com/mate-desktop/atril/issues/290 which has the original patch
2017-09-06pdf: Implement ev_document_text_get_text_attrs()Antia Puentes1-0/+53
origin commit: https://git.gnome.org/browse/evince/commit/?h=gnome-3-10&id=96b9a1
2017-08-28pdf: Reset the annotation mapping when there are no more annotationsGiselle Machado1-0/+2
https://bugzilla.gnome.org/show_bug.cgi?id=649044 origin commit: https://git.gnome.org/browse/evince/commit/?id=06e9129
2017-08-28pdf: Implement remove_annotation virtual funcGermán Poo-Caamaño1-0/+31
https://bugzilla.gnome.org/show_bug.cgi?id=649044 origin commit: https://git.gnome.org/browse/evince/commit/?id=38ca871
2017-08-28pdf: Make annotation names uniqueGiselle Machado1-13/+14
Naming the annotations sequentially by number is problematic when they can be removed (see https://bugzilla.gnome.org/show_bug.cgi?id=649044#c33). This patch changes the annotation names to timestamps, guaranteeing that they are indeed unique. https://bugzilla.gnome.org/show_bug.cgi?id=649044 origin commit: https://git.gnome.org/browse/evince/commit/?id=0f38a27 fix build warning: https://git.gnome.org/browse/evince/commit/?id=6197eba
2017-08-28pdf: Add support for adding other types of annotationsGiselle Machado1-9/+16
Implementing switch/case to support new annotations as they are implemented. origin commit: https://git.gnome.org/browse/evince/commit/?id=320d10f
2017-08-28pdf: Add activation link for Fields that have it.José Aliste1-2/+8
origin commit: https://git.gnome.org/browse/evince/commit/?h=gnome-3-10&id=01254fb
2017-08-20dvi: Mitigate command injection attacks by quoting filenameTobias Mueller1-2/+4
With commit 1fcca0b8041de0d6074d7e17fba174da36c65f99 came a DVI backend. It exports to PDF via the dvipdfm tool. It calls that tool with the filename of the currently loaded document. If that filename is cleverly crafted, it can escape the currently used manual quoting of the filename. Instead of manually quoting the filename, we use g_shell_quote. https://bugzilla.gnome.org/show_bug.cgi?id=784947 origin commit: https://git.gnome.org/browse/evince/commit/?id=350404c
2017-08-20mdvi-lib: Fix compilation warning (const-correctness)Tobias Mueller1-1/+1
const char accessed via pointer to char. backend/dvi/mdvi-lib/fontmap.c: In function ‘mdvi_init_fontmaps’: backend/dvi/mdvi-lib/fontmap.c:725:9: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] config = kpse_cnf_get("mdvi-config"); ^ https://bugzilla.gnome.org/show_bug.cgi?id=784912 origin commit: https://git.gnome.org/browse/evince/commit/?id=e3dccc1
2017-07-21comics: make the files containing "--checkpoint-action=" unsupportedZenWalker1-0/+6
Fixes #257
2016-11-30comics backend: add support for unarchiver (unar and lsar)ZenWalker1-2/+30
unar is able to extract all supported comics archive format CBR give unar priority over bsdtar, because it works better CBZ CB7 CBT give bsdtar priority over unar, because it is much faster
2016-10-31djvu: support image/vnd.djvu+multipage MIME typemonsta1-1/+1
more info at: https://git.gnome.org/browse/evince/commit/?id=7850b986cf3225369170cdec545844b025bfd12e
2016-10-21comics: support application/vnd.comicbook+zip MIME typemonsta1-1/+1
more info at: https://git.gnome.org/browse/evince/commit/?id=71b1323
2016-10-21comics: fix MIME type comparisonsmonsta1-8/+8
taken from: https://git.gnome.org/browse/evince/commit/?id=364b340
2016-10-21comics: fix indentmonsta1-24/+24
2016-10-20tiff: use function from cairo >= 1.6 unconditionallymonsta1-4/+0
no need for additional checks these days (and we actually already use the same function in another file)
2016-10-14Fix case sensitive searching for PDFCormac Walsh1-1/+5
2016-07-28djvu: remove unneeded assignmentmonsta1-4/+1
from https://git.gnome.org/browse/evince/commit/?id=d5ab5564e1b2e99e4939a4fb5a683e9be814bcbe
2016-07-28comics: properly open files with special characters in pathmonsta1-1/+1
from https://git.gnome.org/browse/evince/commit/?id=c648cb2aa38c5004fc091d0067d63aa3beee748f
2016-07-03tiff: issue warnings on print errorsraveit651-6/+17
taken from: https://git.gnome.org/browse/evince/commit/?id=3f85a30
2016-07-03tiff: fix compile warningraveit651-1/+1
taken from: https://git.gnome.org/browse/evince/commit/?id=2059456 https://git.gnome.org/browse/evince/commit/?id=00b5e55
2016-07-03tiff: Fix for -Wformat-nonliteral warningsraveit651-17/+15
taken from: https://git.gnome.org/browse/evince/commit/?id=f688561
2016-06-29dvi: Use new font name instead of the old oneraveit651-1/+1
https://bugzilla.gnome.org/show_bug.cgi?id=612298 taken from: https://git.gnome.org/browse/evince/commit/?id=8bab924
2016-06-29dvi: Use t1 font mapping filesraveit651-1/+6
http://bugzilla.gnome.org/show_bug.cgi?id=612298 taken from: https://git.gnome.org/browse/evince/commit/?id=dfbd28dfd9d790b5a3f39890f66a2da9a0d1c759
2016-06-29xps: Fill version information of EvDocumentBackendInforaveit651-2/+1
https://git.gnome.org/browse/evince/commit/?id=3fee54a
2016-06-29comics: Fix some memory leaksraveit651-19/+22
http://bugzilla.gnome.org/show_bug.cgi?id=667258 taken from: https://git.gnome.org/browse/evince/commit/?id=d397c6d
2016-06-24Fix undefined variable warnings in dvi-backendraveit651-6/+6
taken from: https://git.gnome.org/browse/evince/commit/?id=c8ce06b
2016-06-01backend: drop some win32-specific stuffmonsta6-138/+3
2016-05-25backend, libdocument: reorganize some includesmonsta2-4/+0
2015-12-17Fix crash for epubs when accessibility is enabledAndrey Gursky1-0/+11
Once epub support has been implemented, atril crashes with all epubs. Backtrace for 1.10.2+repack1-1 (Debian Stretch): Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffd26d2700 (LWP 22276)] 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in () #1 0x00007ffff755914e in ev_job_page_data_run (job=0x9e3850 [EvJobPageData]) at ev-jobs.c:762 #2 0x00007ffff755a85a in ev_job_thread_proxy (job=0x9e3850 [EvJobPageData]) at ev-job-scheduler.c:184 #3 0x00007ffff755a85a in ev_job_thread_proxy (data=<optimized out>) at ev-job-scheduler.c:217 #4 0x00007ffff14e1955 in g_thread_proxy (data=0x7fff84002280) at /build/glib2.0-VKSJTv/glib2.0-2.46.1/./glib/gthread.c:778 #5 0x00007ffff08690a4 in start_thread (arg=0x7fffd26d2700) at pthread_create.c:309 #6 0x00007ffff059e06d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111 (gdb) It turns out it couldn't really work since one function pointer is uninitialized. But nobody complained. Thus I investigated it further, why it fails only for me. First, I tried a gtk3 version. And it works properly, but the broken code is not hit at all. Due to the threaded design, it was harder to figure out, why. Here is the code path: --> ev_window_load_job_cb (shell/ev-window.c) --> ev_document_model_set_document (libview/ev-document-model.c) --> ev_view_document_changed_cb (libview/ev-view.c) --> setup_caches (libview/ev-view.c) --> if (ev_view_is_a11y_enabled (view)) { ev_page_cache_set_flags(); } ev_page_cache_set_flags (libview/ev-page-cache.c) --> ev_page_cache_set_page_range (libview/ev-page-cache.c) --> data->job = ev_job_page_data_new (cache->document, i, flags); ... ev_job_scheduler_push_job (data->job, EV_JOB_PRIORITY_NONE); ... --> ev_job_thread_proxy (libview/ev-job-scheduler.c) --> ev_job_page_data_run (libview/ev-jobs.c) --> ev_document_links_get_links (libdocument/ev-document-links.c) --> EvDocumentLinksInterface *iface = EV_DOCUMENT_LINKS_GET_IFACE (document_links); return iface->get_links (document_links, page); (get_links == NULL) --> crash As one can see it depends on the accessibility. And it is enabled on my box. It can be reproduced with gsettings set org.mate.interface accessibility true (mate logout and login) Why the enabled accessibility is not discovered by the gtk3 version is another story. My question [1] was motivated by this. [1] https://github.com/mate-desktop/atril/issues/171