summaryrefslogtreecommitdiff
path: root/shell/ev-sidebar-thumbnails.c
AgeCommit message (Collapse)AuthorFilesLines
2020-04-15Fix cppcheck [knownConditionTrueFalse] warningsPablo Barciela1-11/+4
Fixes the warnings: backend/comics/comics-document.c:767:21: style: Condition 'bytes<=0' is always true [knownConditionTrueFalse] backend/epub/minizip/unzip.c:603:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse] properties/ev-properties-view.c:197:33: style: Condition 'text' is always true [knownConditionTrueFalse] shell/ev-sidebar-thumbnails.c:598:7: style: Condition '!loading_icon' is always true [knownConditionTrueFalse] shell/main.c:115:6: style: Condition '!error' is always true [knownConditionTrueFalse]
2020-01-19Revert "Fix memory leak in ev_sidebar_thumbnails_document_changed_cb()"raveit651-8/+4
This reverts commit bb8194a94310dae72bcbd745cd7f0f93e8d6fad1. Commit cases a warning when closing atril window, see https://github.com/mate-desktop/atril/pull/431#issuecomment-576002680 for more info
2020-01-15Fix memory leak inEric R. Schulz1-4/+8
ev_sidebar_thumbnails_document_changed_cb() Clear the loading icon hash table if it already exists. https://bugzilla.gnome.org/show_bug.cgi?id=770070 origin commit: https://gitlab.gnome.org/GNOME/evince/commit/702c7c6
2019-08-16ev-sidebar-thumbnails: avoid 'g_type_class_add_private'Pablo Barciela1-6/+2
2019-07-01Remove trailing whitespacesLaurent Napias1-20/+20
2017-08-15sidebar-thumbnails: fix unwanted move to start after fullscreenNelson Benitez Leon1-0/+20
After activating or deactivating fullscreen mode, the sidebar window is automatically moved to its start, while scroll bar stays in its original position. The sidebar window move is unwanted and unsolicited, and it's most probably caused by GtkIconView or GtkScrolledWindow bug. Workaround this by having the sidebar sync its window with the current scroll position after a fullscreen operation, do that by just emitting a "value-changed" on the current scroll adjustment. https://bugzilla.gnome.org/show_bug.cgi?id=783404 origin commit: https://git.gnome.org/browse/evince/commit/?id=2bfb8fa
2017-08-15sidebar-thumbnails: preload one extra visible range while scrollingNelson Benitez Leon1-0/+8
Preload both before and after current visible scrolling range, the same amount of thumbnails in it, to help prevent thumbnail creation happening in the user's sight. https://bugzilla.gnome.org/show_bug.cgi?id=342110#c15 origin commit: https://git.gnome.org/browse/evince/commit/?id=1fc8c68
2017-08-15sidebar-thumbnails: keep thumbnails already renderedNelson Benitez Leon1-23/+12
Evince renders thumbnails on-the-fly as they get into the scrolling visible area, but at the same time it will remove them as they get out of the visible scrolling area, so when user scrolls back to same position he will notice thumbnails be recreated. In pro of a more icing user experience, let's adopt a mixed approach and keep the thumbnails that the user has already navigated, so when he scrolls back and forth in the same area no thumbnail re-generation will be visible. This also matches behaviour with other pdf readers. https://bugzilla.gnome.org/show_bug.cgi?id=342110 origin commit: https://git.gnome.org/browse/evince/commit/?id=121e4d9
2017-08-15sidebar-thumbnails: fix clunky scrollingNelson Benitez Leon1-0/+24
Caused by GtkIconView doing an invalidate and relayout of *all* items in the view anytime we update model data in any indiviual item (which happens with all the items that are getting in and out of the scrolling area while we scroll). This caused GtkIconView to machine-gunned us with "size-allocate" signals, a signal we were using to update thumbnails when the sidebar is resized. Fixed by connecting to the GtkTreeModel "row-changed" signal before GtkIconView does it, and stop emission from there. As we don't depend now on "size-allocate" signals to show thumbnails while we scroll, just queue a draw on the icon view when a thumbnail finish rendering. Thanks Jose Aliste for first spotting the problem. https://bugzilla.gnome.org/show_bug.cgi?id=691448 origin commit: https://git.gnome.org/browse/evince/commit/?id=6480c70 Fixes https://github.com/mate-desktop/atril/issues/255
2016-11-23move to GTK+3 (>= 3.14), drop GTK+2 code and --with-gtk build optionmonsta1-12/+2
and require caja >= 1.17.1
2016-06-22Do not use deprecated GTK_TYPE_VBOX definitionsraveit651-1/+3
2014-12-10Using scroll_to_path instead of set_cursor in sidebarinfirit1-1/+1
To prevent the sidebar to get the focus when selected thumbnail changes. Taken from evince commit: cb55d59b7122e8d06f75c5318910b1b8113d3aac From: danigm <[email protected]> Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=639408
2014-12-08sidebar-thumbnails: connect to job finished signal before scheduling the jobmonsta1-4/+4
taken from https://git.gnome.org/browse/evince/commit/?id=6b0630f8c2abd992d65075152dce5fefd9b51f45
2014-08-14Inverted colors(night) viewing mode for ePubrootavish1-1/+1
Added the capability to view and epub document with inverted colors, yet to test for documents where we write the stylesheet, although the code is there.
2014-08-06Redesigned the thumbnail code for ePubrootavish1-1/+4
No more crashes when searching with the sidebar open, will probably add a pixbuf cache as well to speed it up even further. The process which I earlier thought was not possible without separate jobs, work just fine as a single job, if I change the run mode of the thumbnail job, and incorporate a trylock() in case of epub.
2014-07-21Program no longer segfaults, but does not give thumbnailsrootavish1-3/+0
The loading icons for all thumbnails are displayed, but the program does not segfault. Also realized that the absurd resizing of the window was due to the ephy-zoom action on the webview window. Will fix that in the next commit. Will also think of some workaround for screenshots. For now committed this code so that this can act as a clean slate if I screw up somewhere.
2014-07-19Thumbnails for all documentsrootavish1-6/+20
Now other problems with webkit. After much fidgeting I was able to resolve the previous problems of threads. However, now there is a different webkit error.
2014-01-24Fix thumbnails sidebar resizing issues with GTK3Stefano Karapetsas1-1/+30
Closes #58 https://github.com/mate-desktop/atril/issues/58 https://git.gnome.org/browse/evince/commit/shell/ev-sidebar-thumbnails.c?id=a621f05b42468606c8a04446d54b637ecdd05c9b https://git.gnome.org/browse/evince/commit/shell/ev-sidebar-thumbnails.c?id=1e88e7fd7630c28453475e48b98941ce11b130a6
2014-01-21shell: Add GTK3 supportStefano Karapetsas1-2/+0
2011-11-09renaming evince to atrilPerberos1-3/+3
2011-11-09inicialPerberos1-0/+974