diff options
| author | ns <[email protected]> | 2023-10-10 16:10:48 +0000 |
|---|---|---|
| committer | raveit65 <[email protected]> | 2023-10-14 09:46:31 +0200 |
| commit | 22df555ebe785c023471e6de3da7e037fc7f3b94 (patch) | |
| tree | 694a03101847cd046fb9ccef5c28727ec926ec92 | |
| parent | ee84552160f9c22ad696969e837793f53c975d46 (diff) | |
| download | marco-22df555ebe785c023471e6de3da7e037fc7f3b94.tar.bz2 marco-22df555ebe785c023471e6de3da7e037fc7f3b94.tar.xz | |
Allow applications to raise windows when raise_on_click is off.
This is Metacity commit 50358a95 ("Allow applications to raise windows
when raise_on_click is off. Closes #445447.") applied to Marco without
modification.
It also includes a change to the GSettings key's description to remove
the now obsolete warning on the raise-on-click key, & replaces it with
an actually useful description. This is copied from the equivalent key
in gsettings-desktop-schemas.
Fixes: https://github.com/mate-desktop/marco/issues/762
| -rw-r--r-- | src/core/window.c | 3 | ||||
| -rw-r--r-- | src/org.mate.marco.gschema.xml | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/src/core/window.c b/src/core/window.c index de3f9c99..c1702dd8 100644 --- a/src/core/window.c +++ b/src/core/window.c @@ -5025,8 +5025,7 @@ meta_window_configure_request (MetaWindow *window, { MetaWindow *active_window; active_window = window->display->expected_focus_window; - if (meta_prefs_get_disable_workarounds () || - !meta_prefs_get_raise_on_click ()) + if (meta_prefs_get_disable_workarounds ()) { meta_topic (META_DEBUG_STACK, "%s sent an xconfigure stacking request; this is " diff --git a/src/org.mate.marco.gschema.xml b/src/org.mate.marco.gschema.xml index a1297ad0..c8766b44 100644 --- a/src/org.mate.marco.gschema.xml +++ b/src/org.mate.marco.gschema.xml @@ -78,7 +78,7 @@ <key name="raise-on-click" type="b"> <default>true</default> <summary>Whether raising should be a side-effect of other user interactions</summary> - <description>Setting this option to false can lead to buggy behavior, so users are strongly discouraged from changing it from the default of true. Many actions (e.g. clicking in the client area, moving or resizing the window) normally raise the window as a side-effect. Setting this option to false, which is strongly discouraged, will decouple raising from other user actions, and ignore raise requests generated by applications. See http://bugzilla.gnome.org/show_bug.cgi?id=445447#c6. Even when this option is false, windows can still be raised by an alt-left-click anywhere on the window, a normal click on the window decorations, or by special messages from pagers, such as activation requests from tasklist applets. This option is currently disabled in click-to-focus mode. Note that the list of ways to raise windows when raise_on_click is false does not include programmatic requests from applications to raise windows; such requests will be ignored regardless of the reason for the request. If you are an application developer and have a user complaining that your application does not work with this setting disabled, tell them it is _their_ fault for breaking their window manager and that they need to change this option back to true or live with the "bug" they requested.</description> + <description>The default, true, indicates that a window will be raised whenever its client area or its frame is clicked. Setting this to false means that a window will not be raised if it is clicked on the client area.</description> </key> <key name="action-double-click-titlebar" enum="org.mate.Marco.ActionTitlebar"> <default>'toggle_maximize'</default> |