summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrbuj <[email protected]>2019-03-12 09:15:20 +0100
committerlukefromdc <[email protected]>2019-04-12 02:10:59 +0000
commit0be07a3500d67b240f77874cff989d3fe7026a34 (patch)
treec1165d576c46fa6bd72dc250259d0bdb50c69217
parent94759b354850fabd29028f2f6b3b6077534eaaae (diff)
downloadmate-control-center-0be07a3500d67b240f77874cff989d3fe7026a34.tar.bz2
mate-control-center-0be07a3500d67b240f77874cff989d3fe7026a34.tar.xz
Remove dead store detected by clang
marco-window-manager.c:408:17: warning: Value stored to 'i' is never read i = 0; ^ ~ theme-installer.c:813:3: warning: Value stored to 'filename' is never read filename = old_folder; ^ ~~~~~~~~~~
-rw-r--r--capplets/appearance/appearance-themes.c2
-rw-r--r--capplets/appearance/theme-installer.c6
-rw-r--r--capplets/appearance/theme-installer.h2
-rw-r--r--libwindow-settings/marco-window-manager.c1
4 files changed, 3 insertions, 8 deletions
diff --git a/capplets/appearance/appearance-themes.c b/capplets/appearance/appearance-themes.c
index 1028d830..3bce0077 100644
--- a/capplets/appearance/appearance-themes.c
+++ b/capplets/appearance/appearance-themes.c
@@ -802,7 +802,7 @@ static void
theme_install_cb (GtkWidget *button, AppearanceData *data)
{
mate_theme_installer_run (
- GTK_WINDOW (appearance_capplet_get_widget (data, "appearance_window")), NULL);
+ GTK_WINDOW (appearance_capplet_get_widget (data, "appearance_window")));
}
static void
diff --git a/capplets/appearance/theme-installer.c b/capplets/appearance/theme-installer.c
index c79704e9..93e1ef0a 100644
--- a/capplets/appearance/theme-installer.c
+++ b/capplets/appearance/theme-installer.c
@@ -796,8 +796,7 @@ mate_theme_install (GFile *file,
}
void
-mate_theme_installer_run (GtkWindow *parent,
- const gchar *filename)
+mate_theme_installer_run (GtkWindow *parent)
{
static gboolean running_theme_install = FALSE;
static gchar old_folder[512] = "";
@@ -809,9 +808,6 @@ mate_theme_installer_run (GtkWindow *parent,
running_theme_install = TRUE;
- if (filename == NULL)
- filename = old_folder;
-
dialog = gtk_file_chooser_dialog_new (_("Select Theme"),
parent,
GTK_FILE_CHOOSER_ACTION_OPEN,
diff --git a/capplets/appearance/theme-installer.h b/capplets/appearance/theme-installer.h
index 1718b124..44326982 100644
--- a/capplets/appearance/theme-installer.h
+++ b/capplets/appearance/theme-installer.h
@@ -23,6 +23,6 @@
#define THEME_INSTALLER_H
void mate_theme_install (GFile *file, GtkWindow *parent);
-void mate_theme_installer_run (GtkWindow *parent, const gchar *filename);
+void mate_theme_installer_run (GtkWindow *parent);
#endif /* THEME_INSTALLER_H */
diff --git a/libwindow-settings/marco-window-manager.c b/libwindow-settings/marco-window-manager.c
index 5ce68dfb..489d210d 100644
--- a/libwindow-settings/marco-window-manager.c
+++ b/libwindow-settings/marco-window-manager.c
@@ -405,7 +405,6 @@ marco_get_double_click_actions (MateWindowManager *wm,
int i;
initialized = TRUE;
- i = 0;
for (i = 0; i < G_N_ELEMENTS (actions); i++) {
actions[i].human_readable_name = _(actions[i].human_readable_name);
}