diff options
| author | raveit65 <[email protected]> | 2020-01-01 19:13:49 +0100 |
|---|---|---|
| committer | raveit65 <[email protected]> | 2020-01-09 00:06:04 +0100 |
| commit | 298af2236e8f23064f00b03bedc7780a6456a5bf (patch) | |
| tree | 5b1d718cd3aa79703bdf0c6c3609135b4db8372e /libmate-desktop | |
| parent | 772cf7f8bc20122213bee2fbbf0c46885b4db83b (diff) | |
| download | mate-desktop-298af2236e8f23064f00b03bedc7780a6456a5bf.tar.bz2 mate-desktop-298af2236e8f23064f00b03bedc7780a6456a5bf.tar.xz | |
thumbnail: Demote a log message from WARNING to DEBUG
Failure to create a GdkPixbufLoader for a specific MIME type doesn't
necessarily indicate an error. It is possible that the fallback code
would still be able to parse the image data. For example, Canon CR2 RAW
files have the MIME type image/x-canon-cr2. While we don't have a
loader for that specific MIME type, the TIFF loader can still parse the
data.
In case the fallback code failed to parse the image data, we get a
WARNING anyway:
MateDesktop-WARNING **: Error creating thumbnail for ...
Having a log message to indicate that we are using the fallback code is
useful for debugging, but there is no need for the WARNING. It can be
extra noise and needlessly interferes with things like
G_DEBUG=fatal-warnings.
https://bugzilla.gnome.org/show_bug.cgi?id=762504
origin commit:
https://gitlab.gnome.org/GNOME/gnome-desktop/commit/7507254
Diffstat (limited to 'libmate-desktop')
| -rw-r--r-- | libmate-desktop/mate-desktop-thumbnail.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libmate-desktop/mate-desktop-thumbnail.c b/libmate-desktop/mate-desktop-thumbnail.c index 6678f74..b3ed537 100644 --- a/libmate-desktop/mate-desktop-thumbnail.c +++ b/libmate-desktop/mate-desktop-thumbnail.c @@ -322,7 +322,7 @@ create_loader (GFile *file, } if (loader == NULL && error != NULL) { - g_warning ("Unable to create loader for mime type %s: %s", mime_type, error->message); + g_debug ("Unable to create loader for mime type %s: %s", mime_type, error->message); g_clear_error (&error); loader = gdk_pixbuf_loader_new (); } |