summaryrefslogtreecommitdiff
path: root/mate-panel/panel-run-dialog.c
AgeCommit message (Collapse)AuthorFilesLines
2024-01-25run-dialog: Don't needlessly override DISPLAY environment variableColomban Wendling1-20/+2
This code got introduced with 3c21f66bf30810fcb25dfe8c3c0960df270dc416 trying to mimic `gdk_spawn_on_screen()`, but does not: what `gdk_spawn_on_screen()` did (on X11) was to append the screen number to the display, so that it worked on a multi-screen setup where the app is not on the default X screen. However, the code that got introduced just sets the display, which is gonna be already there anyway (yet possibly loosing the default screen in the process?), and AFAIK GDK dropped support for multi-screen setups anyway (not to be confused with multi-monitor with e.g. Xinerama). We should actually be better of without any of this, as it most likely doesn't do what it is supposed to, nobody needs what it failed to do, and it breaks XWayland on Wayland. Fixes #1387.
2023-11-21Do not perform useless incoherent NULL checkColomban Wendling1-1/+1
cppcheck tells us that we perform NULL checking inconsistently, and reports a potential NULL dereference. Here however the string cannot be NULL, so just drop the unnecessary check. > mate-panel/panel-run-dialog.c:1663:10: warning: Either the condition '!start' is redundant or there is possible null pointer dereference: start. [nullPointerRedundantCheck] > while (*start != '\0' && g_ascii_isspace (*start)) > ^ > mate-panel/panel-run-dialog.c:1679:6: note: Assuming that condition '!start' is not redundant > if (!start || !start [0]) { > ^ > mate-panel/panel-run-dialog.c:1663:10: note: Null pointer dereference > while (*start != '\0' && g_ascii_isspace (*start)) > ^
2023-11-21Reorder array index limit checkColomban Wendling1-3/+1
This is *not* an issue, as it's not really a bounds check but a mere limit, and the array is NULL-terminated. However, it looks odd and cppcheck (unsurprisingly) doesn't understand the details well enough and reports this as a misordered bounds check. > mate-panel/panel-run-dialog.c:166:12: style: Array index 'i' is used before limits check. [arrayIndexThenCheck] > items[i] && i < history_max_size; > ^
2023-05-07panel-run-dialog: Add accelerator keys for "list of known applications" (#1359)Matthias Reis1-20/+136
* panel-run-dialog: Add accelerator keys for "list of known applications" in panel run dialog, display modifier keys by using GtkCellRendererAccel * fixup! panel-run-dialog: Add accelerator keys for "list of known applications" in panel run dialog, display modifier keys by using GtkCellRendererAccel * fixup! fixup! panel-run-dialog: Add accelerator keys for "list of known applications" in panel run dialog, display modifier keys by using GtkCellRendererAccel * fixup! fixup! fixup! panel-run-dialog: Add accelerator keys for "list of known applications" in panel run dialog, display modifier keys by using GtkCellRendererAccel * fixup! fixup! fixup! fixup! panel-run-dialog: Add accelerator keys for "list of known applications" in panel run dialog, display modifier keys by using GtkCellRendererAccel
2022-01-18panel-run-dialog: address of array 'dent->d_name' will always evaluate to 'true'rbuj1-2/+1
2021-12-20Fix some -Wsign-compare warningsrbuj1-3/+3
2021-12-19Use dashes instead of underscores in signal namesrbuj1-2/+2
2021-12-16Use g_clear_pointer() and g_clear_object()rbuj1-19/+9
2021-12-11Use a blank line at mostrbuj1-1/+0
2021-08-03Use absolute path g_get_home_dir replaces "~/"zhuyaliang1-0/+15
2021-06-22update copyright to 2021raveit651-0/+1
2021-04-25Replace deprecated GCompletion with GtkEntryCompletionzhuyaliang1-53/+37
2020-09-07Remove variableScope warnings reported by cppcheckrbuj1-33/+22
cppcheck --enable=all . 2> err.txt grep variableScope err.txt
2020-07-29panel-run-dialog: Fix leaking tree model stringsTomas Bzatek1-6/+18
The gtk_tree_model_get() duplicates memory or adds a reference and any data need to be freed explicitly.
2020-07-05Avoid using single-line cpp commentsrbuj1-5/+6
2019-07-05Remove trailing whitespacesLaurent Napias1-1/+1
2019-06-21Update to the new panel_multimonitor functionsWilliam Wold1-4/+1
2019-06-21Rename panel-multiscreen files panel-multimonitorWilliam Wold1-1/+1
2019-03-10Wayland support for panel-run-dialog.cWilliam Wold1-3/+9
2018-05-30Support new mate-menus apiyetist1-65/+83
2018-04-26panel: Convert to GResourceVincent Untz1-23/+4
origin commits: https://git.gnome.org/browse/gnome-panel/commit/?h=gnome-3-4&id=9fca67f https://git.gnome.org/browse/gnome-panel/commit/?h=gnome-3-4&id=695d30c https://git.gnome.org/browse/gnome-panel/patch/?id=00f9870cb28e6ef657d1
2018-04-17avoid 'gtk_file_chooser_dialog_new' with stock idsPablo Barciela1-6/+6
2018-03-19run dialog: force icon size when loading app iconmonsta1-1/+1
avoids jumping of nearby UI controls when icon is bigger than requested
2018-03-18Fix run dialog show-program-list enabling fixinfo-cppsp1-3/+18
learning signal chaining...
2018-03-14run-dialog: use F6 to switch between entry field and program listinfo-cppsp1-0/+33
fix #676
2018-02-24Scale monitor geometries down to device pixels to support multiple monitors ↵Victor Kareh1-3/+1
in HiDPI
2018-01-31Fix run dialog show-program-list enablinginfo-cppsp1-7/+20
fix #296
2018-01-31panel-run-dialog: fix build warning about incompatible typemonsta1-1/+1
introduced in 7f99492c269f541c81e4f36742ecc3f0b4ebac04
2018-01-25avoid deprecated GtkStockPablo Barciela1-2/+2
2018-01-25Support panel auto-scaling for HiDPI displaysVictor Kareh1-1/+3
*Fix scaling of panel widgets, buttons, and the menu bar *Draw grab handles at the ends of the panel *Fix size of _almost_ all included applets *Fix panel snapping coordinates *Down-scale monitor coordinates to support multi-monitors Author: Victor Kareh <[email protected]> Date: Wed Dec 20 14:03:18 2017 -0500
2018-01-19panel-run-dialog: fix segfault when program list is enabledlukefromdc1-3/+7
Fix https://github.com/mate-desktop/mate-panel/issues/706 *patch by https://github.com/muesli4
2017-08-02avoid deprecated gdk_screen_make_display_nameZenWalker1-3/+6
2017-04-19fix build with gcc 4.9.2 (looks like it's in c89 mode by default)monsta1-1/+2
2017-04-18Run dialog: Add option to reverse history viewMoritz Bruder1-22/+38
A setting is added to show the run dialog history in reverse.
2017-04-18Run dialog: Fix wrong history len with max size 1Moritz Bruder1-17/+16
In a special case where the history size was 1, the actual history saved had length 2. In addition history is always written with new entries. One could also connect a signal to the max size property to force writing history (i.e., to shorten it).
2017-04-18Run dialog: Allow changing history sizeMoritz Bruder1-26/+33
A key has been added to the gsettings schema that controls history size. The code of the run dialog has been changed to use that key.
2017-04-17Run dialog: Fix wrong history orderMoritz Bruder1-1/+1
Initially the org.mate.panel.general.history-mate-run key was saved with the most recent command last. In combination with wrong code this led to scrambling the history. This commit changes the history storage in a way that most recent elements are stored first. The code adapts to this change by changing only one function to prepend instead of append in the list store. (Any old histories might therefore be wrong for a short time, but that's probably worth it to fix this bug.)
2017-01-05remove ancient code leftoversmonsta1-19/+0
once it was some easter egg, now it's just a non-working garbage
2016-11-21move to GTK+3 (>= 3.14), drop GTK+2 code and --with-gtk build optionmonsta1-28/+1
and require libmate-desktop >= 1.17 WARNING: use GTK+3 build of libmateweather for this build. that lib is not migrated to GTK+3 only as we will possibly use libgweather instead of it.
2015-10-25run dialog: make app description label unfocusableMonsta1-0/+2
2015-09-04panel-run-dialog: Use g_spawn_async in both Gtk versions.infirit1-19/+17
2015-08-26Gtk3: fixed build warningyetist1-2/+4
2014-11-23don't leak memoryMonsta1-1/+1
2014-11-23panel: Add panel_run_dialog_get_combo_text() helperinfirit1-4/+14
Instead of writing some long line again and again, use a small helper. Taken from gnome-panel commit: 412ac2e4fa6a19c454b7046b9f57b9622a7b97d0 From: Vincent Untz <[email protected]>
2014-11-23Gtk3: panel-run-dialog: Use style-updated signal instead of style-setinfirit1-0/+17
Based on gnome-panel commit: b4deac9d217b4785d2c930a2deb2d94f5e4878d9 From: Carlos Garcia Campos <[email protected]>
2014-11-18use gtk icon(pixmap) cache insteadof custom oneDenis Gorodnichev1-124/+56
2014-05-04gtk3: fix run application dialogDenis Gorodnichev1-20/+2
2013-12-22Update help uri to the correct locationinfirit1-1/+1
2013-10-26mate-panel: Add GTK3 supportStefano Karapetsas1-13/+44
2013-02-05Avoid-double-forking-when-launching-apps-it-breaksraveit1-2/+16
generated by cgit v1.2.1 (git 2.18.0) at 2024-04-28 13:23:53 +0000