summaryrefslogtreecommitdiff
path: root/plugins/a11y-keyboard
diff options
context:
space:
mode:
Diffstat (limited to 'plugins/a11y-keyboard')
-rw-r--r--plugins/a11y-keyboard/msd-a11y-keyboard-atspi.c13
-rw-r--r--plugins/a11y-keyboard/msd-a11y-keyboard-atspi.h1
-rw-r--r--plugins/a11y-keyboard/msd-a11y-keyboard-manager.c6
-rw-r--r--plugins/a11y-keyboard/msd-a11y-keyboard-manager.h1
-rw-r--r--plugins/a11y-keyboard/msd-a11y-keyboard-plugin.c1
-rw-r--r--plugins/a11y-keyboard/msd-a11y-keyboard-plugin.h1
-rw-r--r--plugins/a11y-keyboard/msd-a11y-preferences-dialog.c59
-rw-r--r--plugins/a11y-keyboard/msd-a11y-preferences-dialog.h1
-rw-r--r--plugins/a11y-keyboard/test-a11y-preferences-dialog.c1
9 files changed, 44 insertions, 40 deletions
diff --git a/plugins/a11y-keyboard/msd-a11y-keyboard-atspi.c b/plugins/a11y-keyboard/msd-a11y-keyboard-atspi.c
index 0873f0a..a45ef47 100644
--- a/plugins/a11y-keyboard/msd-a11y-keyboard-atspi.c
+++ b/plugins/a11y-keyboard/msd-a11y-keyboard-atspi.c
@@ -1,6 +1,7 @@
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2020 Colomban Wendling <[email protected]>
+ * Copyright (C) 2012-2021 MATE Developers
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -54,16 +55,16 @@ msd_a11y_keyboard_atspi_class_init (MsdA11yKeyboardAtspiClass *klass)
}
static gboolean
-on_key_press_event (const AtspiDeviceEvent *event,
- void *user_data G_GNUC_UNUSED)
+on_key_press_event (AtspiDeviceEvent *event,
+ void *user_data G_GNUC_UNUSED)
{
/* don't ring on capslock itself, that's taken care of by togglekeys
* if the user want it. */
- if (event->id == GDK_KEY_Caps_Lock)
- return FALSE;
-
- gdk_display_beep (gdk_display_get_default ());
+ if (event->id != GDK_KEY_Caps_Lock)
+ gdk_display_beep (gdk_display_get_default ());
+ /* cast the possible erroneous const away with atspi < 2.40 */
+ g_boxed_free (ATSPI_TYPE_DEVICE_EVENT, (gpointer) event);
return FALSE;
}
diff --git a/plugins/a11y-keyboard/msd-a11y-keyboard-atspi.h b/plugins/a11y-keyboard/msd-a11y-keyboard-atspi.h
index fc97494..ec0c02b 100644
--- a/plugins/a11y-keyboard/msd-a11y-keyboard-atspi.h
+++ b/plugins/a11y-keyboard/msd-a11y-keyboard-atspi.h
@@ -1,6 +1,7 @@
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2020 Colomban Wendling <[email protected]>
+ * Copyright (C) 2012-2021 MATE Developers
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/plugins/a11y-keyboard/msd-a11y-keyboard-manager.c b/plugins/a11y-keyboard/msd-a11y-keyboard-manager.c
index e383ebd..d354db5 100644
--- a/plugins/a11y-keyboard/msd-a11y-keyboard-manager.c
+++ b/plugins/a11y-keyboard/msd-a11y-keyboard-manager.c
@@ -2,6 +2,7 @@
*
* Copyright © 2001 Ximian, Inc.
* Copyright (C) 2007 William Jon McCann <[email protected]>
+ * Copyright (C) 2012-2021 MATE Developers
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -202,8 +203,7 @@ get_xkb_desc_rec (MsdA11yKeyboardManager *manager)
}
gdk_x11_display_error_trap_pop_ignored (display);
- g_return_val_if_fail (desc != NULL, NULL);
- g_return_val_if_fail (desc->ctrls != NULL, NULL);
+ g_return_val_if_fail (desc != NULL && desc->ctrls != NULL, NULL);
g_return_val_if_fail (status == Success, NULL);
return desc;
@@ -640,7 +640,6 @@ ax_slowkeys_warning_post_bubble (MsdA11yKeyboardManager *manager,
#endif /* HAVE_LIBNOTIFY */
}
-
static void
ax_slowkeys_warning_post_dialog (MsdA11yKeyboardManager *manager,
gboolean enabled)
@@ -1144,7 +1143,6 @@ start_a11y_keyboard_idle_cb (MsdA11yKeyboardManager *manager)
return FALSE;
}
-
gboolean
msd_a11y_keyboard_manager_start (MsdA11yKeyboardManager *manager,
GError **error)
diff --git a/plugins/a11y-keyboard/msd-a11y-keyboard-manager.h b/plugins/a11y-keyboard/msd-a11y-keyboard-manager.h
index b27a00f..050eed6 100644
--- a/plugins/a11y-keyboard/msd-a11y-keyboard-manager.h
+++ b/plugins/a11y-keyboard/msd-a11y-keyboard-manager.h
@@ -1,6 +1,7 @@
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2007 William Jon McCann <[email protected]>
+ * Copyright (C) 2012-2021 MATE Developers
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/plugins/a11y-keyboard/msd-a11y-keyboard-plugin.c b/plugins/a11y-keyboard/msd-a11y-keyboard-plugin.c
index ef84510..5679fa4 100644
--- a/plugins/a11y-keyboard/msd-a11y-keyboard-plugin.c
+++ b/plugins/a11y-keyboard/msd-a11y-keyboard-plugin.c
@@ -1,6 +1,7 @@
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2007 William Jon McCann <[email protected]>
+ * Copyright (C) 2012-2021 MATE Developers
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/plugins/a11y-keyboard/msd-a11y-keyboard-plugin.h b/plugins/a11y-keyboard/msd-a11y-keyboard-plugin.h
index 7967107..a2dfd7b 100644
--- a/plugins/a11y-keyboard/msd-a11y-keyboard-plugin.h
+++ b/plugins/a11y-keyboard/msd-a11y-keyboard-plugin.h
@@ -1,6 +1,7 @@
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2007 William Jon McCann <[email protected]>
+ * Copyright (C) 2012-2021 MATE Developers
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/plugins/a11y-keyboard/msd-a11y-preferences-dialog.c b/plugins/a11y-keyboard/msd-a11y-preferences-dialog.c
index f0cbb3b..8ef1af6 100644
--- a/plugins/a11y-keyboard/msd-a11y-preferences-dialog.c
+++ b/plugins/a11y-keyboard/msd-a11y-preferences-dialog.c
@@ -1,6 +1,7 @@
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2008 William Jon McCann <[email protected]>
+ * Copyright (C) 2012-2021 MATE Developers
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -30,9 +31,6 @@
#include <glib-object.h>
#include <gtk/gtk.h>
#include <gdk/gdkx.h>
-
-#include <dbus/dbus-glib.h>
-
#include <gio/gio.h>
#include "msd-a11y-preferences-dialog.h"
@@ -41,7 +39,6 @@
#define SM_DBUS_PATH "/org/gnome/SessionManager"
#define SM_DBUS_INTERFACE "org.gnome.SessionManager"
-
#define GTKBUILDER_UI_FILE "msd-a11y-preferences-dialog.ui"
#define KEY_A11Y_SCHEMA "org.mate.accessibility-keyboard"
@@ -343,41 +340,44 @@ config_set_capslock_beep (MsdA11yPreferencesDialog *dialog, gboolean enabled)
static gboolean
config_have_at_gsettings_condition (const char *condition)
{
- DBusGProxy *sm_proxy;
- DBusGConnection *connection;
- GError *error;
- gboolean res;
- gboolean is_handled;
-
- error = NULL;
- connection = dbus_g_bus_get (DBUS_BUS_SESSION, &error);
- if (connection == NULL) {
+ GDBusProxy *proxy = NULL;
+ GError *error = NULL;
+ GVariant *ret;
+ gboolean is_handled;
+
+ proxy = g_dbus_proxy_new_for_bus_sync (G_BUS_TYPE_SYSTEM,
+ G_DBUS_PROXY_FLAGS_NONE,
+ NULL,
+ SM_DBUS_NAME,
+ SM_DBUS_PATH,
+ SM_DBUS_INTERFACE,
+ NULL,
+ &error);
+ if (proxy == NULL) {
g_warning ("Unable to connect to session bus: %s", error->message);
- return FALSE;
- }
- sm_proxy = dbus_g_proxy_new_for_name (connection,
- SM_DBUS_NAME,
- SM_DBUS_PATH,
- SM_DBUS_INTERFACE);
- if (sm_proxy == NULL) {
+ g_error_free (error);
return FALSE;
}
is_handled = FALSE;
- res = dbus_g_proxy_call (sm_proxy,
- "IsAutostartConditionHandled",
- &error,
- G_TYPE_STRING, condition,
- G_TYPE_INVALID,
- G_TYPE_BOOLEAN, &is_handled,
- G_TYPE_INVALID);
- if (! res) {
+ ret = g_dbus_proxy_call_sync (proxy,
+ "IsAutostartConditionHandled",
+ g_variant_new ("(s)", condition),
+ G_DBUS_CALL_FLAGS_NONE,
+ -1,
+ NULL,
+ &error);
+ if (ret == NULL) {
g_warning ("Unable to call IsAutostartConditionHandled (%s): %s",
condition,
error->message);
+ g_error_free (error);
+ } else {
+ g_variant_get (ret, "(b)", &is_handled);
+ g_variant_unref (ret);
}
- g_object_unref (sm_proxy);
+ g_object_unref (proxy);
return is_handled;
}
@@ -840,7 +840,6 @@ msd_a11y_preferences_dialog_init (MsdA11yPreferencesDialog *dialog)
G_CALLBACK (on_response),
dialog);
-
gtk_widget_show_all (GTK_WIDGET (dialog));
}
diff --git a/plugins/a11y-keyboard/msd-a11y-preferences-dialog.h b/plugins/a11y-keyboard/msd-a11y-preferences-dialog.h
index 4011497..780dfa1 100644
--- a/plugins/a11y-keyboard/msd-a11y-preferences-dialog.h
+++ b/plugins/a11y-keyboard/msd-a11y-preferences-dialog.h
@@ -1,6 +1,7 @@
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2008 William Jon McCann <[email protected]>
+ * Copyright (C) 2012-2021 MATE Developers
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/plugins/a11y-keyboard/test-a11y-preferences-dialog.c b/plugins/a11y-keyboard/test-a11y-preferences-dialog.c
index 16d3f92..be2de98 100644
--- a/plugins/a11y-keyboard/test-a11y-preferences-dialog.c
+++ b/plugins/a11y-keyboard/test-a11y-preferences-dialog.c
@@ -1,6 +1,7 @@
/* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 8 -*-
*
* Copyright (C) 2007 William Jon McCann <[email protected]>
+ * Copyright (C) 2012-2021 MATE Developers
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as