summaryrefslogtreecommitdiff
path: root/plugins/a11y-keyboard/msd-a11y-keyboard-atspi.c
AgeCommit message (Collapse)AuthorFilesLines
2023-06-29a11y-keyboard-atspi: Fix memory leakColomban Wendling1-6/+6
Fix fairly large memory leak when beeping on keys while caps lock is enabled. The libatspi2 docs and API were quite misleading, so I overlooked the fact the event parameter should be freed in the callback. This changes the constness of the callback argument, which is new in libatspi2 2.40 -- yet the actual behavior didn't change, only the qualifier was removed, see [1]. This might however bring up a compiler warning when building against libatspi2 < 2.40; but on the other hand it fixed build with clang >= 16, see #399. As it is unlikely to build with clang >= 16 and libatspi2 < 2.40, I think it's a good compromise. [1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/7dfb0b7fc2d1710ef7fad54f910fa4c6a5e3af17
2021-06-23update copyright to 2021raveit651-0/+1
2020-08-08a11y-keyboard: Don't create a dummy object if AT-SPI is not availableColomban Wendling1-33/+0
Instead guard the caller to only use it if available.
2020-08-08a11y-keyboard-atspi: Switch to a final type and reduce boilerplateColomban Wendling1-21/+25
2020-08-08a11y-keyboard: capslock-beep: Try and detect non-buggy libatspi2Colomban Wendling1-10/+7
Try and avoid the workaround for buggy libatspi2 if we can know the version we're using has it fixed.
2020-08-08a11y-keyboard: capslock-beep: Don't ring on CapsLock itselfColomban Wendling1-26/+8
Ringing when a locking modifier gets enabled/disabled is already taken care of by the `togglekeys` settings, so don't provide redundant functionality and allow better settings granularity.
2020-08-08a11y-keyboard: Refactor in the hope the AT-SPI bug gets fixedColomban Wendling1-32/+31
2020-08-08a11y-keyboard: Add support for ringing the bell when CapsLock is activeColomban Wendling1-0/+208